Skip to content

Comments

v4.6.2#3881

Merged
kcondon merged 552 commits intomasterfrom
develop
Jun 2, 2017
Merged

v4.6.2#3881
kcondon merged 552 commits intomasterfrom
develop

Conversation

@kcondon
Copy link
Contributor

@kcondon kcondon commented Jun 2, 2017

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

  • connects to [#issue number]: [issue title]

Pull Request Checklist

Alex Ivanov and others added 30 commits April 13, 2017 23:50
Implemented passive authentication support for Shibboleth
…group to dataset pg. Moved dataset version number into label next to title on dataset and file pgs. [ref #3747]
…datafiles to

go through the DataFileIO drivers.
In other words, tabular ingest and image-related tasks are no longer restricted to
local files.
NOTE: this looks like a MORE SERIOUS CHANGE than it really is! - Because I renamed
a few methods and moved some code around. Let's review this with the whole team.
#3432 : WorldMap: Dataset citations longer than 255 chars cause an error
also stub out logic for actual delete on publish
…747-compute-button-UI

Merging updates in commit cc9d4eb
Updated Cloud Storage Access box to container name
Initial commit so that @mheppler can come on board this branch. This is
a totally unfinished rough draft of half of the Geoconnect user guide.
…date

Updated config docs and container names
…-button-update

Revert "Updated config docs and container names"
add "Data Not Published" popup to file page on "Map Data" click #3760
adds more convenience methods, for hiding underlying write operations from the developer (per Gustavo's feedback);
adds DataFileIO functionality to the dele operations.
dlmurphy and others added 28 commits May 26, 2017 14:00
Edited sentence under Architecture and Components section to make more
sense now that Handles are supported. Also moved a diagram on the page
to lessen confusion over its placement.
Simplified the previously edited line to make it more straightforward
and accurate.
- Make "Persistent Identifiers and Publishing Datasets" its own
  subsection, no longer squished within "Root Dataverse Configuration".
- Make it more clear which settings matter for DOI vs. Handle.
- Other minor tweaks.
Small typo & style fixes
…iceBean

It’s done in the SearchIncludeFragment
descriptions/redirect urls for harvested datasets;
persisting selected thumbnails;
some cleanup.
fixes the optimized lookup of tabular data files;
proper thumbnail generation for worldmap files;
isolates the optimized thumbnail handling in its own ViewScope wrapper;
makes the dataset page call the wrapper to obtain the dataset-level logo for the top of the page, when in optimized mode;
properly implements the persistence of auto-selected thumbnails.
save files permanently in command rather than JSF page #3866
Fix to prep.rst doc for Handles support
…e doomed

dataset has an explicitly assigned thumbnail DataFile.
…afile-constraint

Fixes the constraint violation error in DestroyDataseCommand (3875)
… thumbnail for a dataset, but

has been restricted since then, the assignment will be removed *when the dataset gets published*.
(somewhat similarly to how the map layer for a restricted file gets removed inside PublishDatasetCommand).
…e there, regarding datafiles that are being made restricted).
…ixes

A small change per Gustavo's review: if a datafile is assigned as the…
@kcondon kcondon merged commit b0fd002 into master Jun 2, 2017
@pdurbin pdurbin added this to the 4.6.2 - Tabular Mapping milestone Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.