5717 dialog input focus

[mheppler]

Related Issues

• closes Accessibility - fix keyboard focus for popups/dialogs (e.g. support), change secondary form button (e.g. cancel) style #5717 Accessibility - fix keyboard focus for popups/dialogs (e.g. support), change secondary form button (e.g. cancel) style

Pull Request Checklist

• Unit tests completed
• Integration tests: None
• Deployment requirements, SQL updates, Solr updates, etc.: None
• Documentation completed
• Merged latest from "develop" branch and resolved conflicts

[mheppler]

Outline of all the moving pieces... there are APP-WIDE, ACCOUNT, DASHBOARD, DATAVERSE, DATASET, and FILE sections... individual pages are listed under each section, with specific workflows called out by listing the ID of forms or dialogs in quotes (e.g. "datamove-form")...

APP-WIDE

web.xml

• added mime-mapping for webmanifest file (favicons Favicon - Improve resolution for various display options #5637) to resolve warnings in server log

Bundle.properties

• cleaned up formatting of other bundle text for password request/reset workflows, moved passwordreset.xhtml bundle text up (line 262 now) to be grouped with other passwordreset related text in dataverseuser.xhtml

structure.css

• added styles to fix primefaces ui-button class styles overwriting bootstrap btn-link class styles
• added styles to fix primefaces ui-state-hover class styles overwriting boostrap btn-default class styles

dataverse_template

• removed old "statusInfo" popup that is no longer used (Status Message - Improve UI #4842)

dataverse_header

• removed old static button that was commented out of status msg alert component

contactFormFragment

• added p:focus component to "contactDialog" popup
• changed Save Changes btn from p:commandLink' component to p:commandButton` component
• changed Cancel btn styles from btn-default to btn-link, removed redundant, unnecessary value attribute from button

404

• added p:focus component for "search404" input
• changed layout of input and button to use bootstrap input group
• fixed onkeypress and onclick submit of search issues related to both the new p:focus element as well as an existing issue with custom homepage changing the URL for the root dataverse pg search results

ACCOUNT

dataverseuser

• changed Cancel btn styles from btn-default to btn-link

convert

• added p:focus component to "convertAccountForm" form
• changed Cancel btn styles from btn-default to btn-link

firstLogin

• added p:focus component to "newAccountForm" form

login

• fixed p:message render logic for password input on builtin user form (even if it doesn't seem to be wired up)
• changed update="@all" to update="@form,:messagePanel" for Log In btn on builtin user form to resolve CSS/plain text page flash on refresh (validation error)

passwordreset

• added p:focus component to "passwordReset" form
• added p:focus component to "passwordResetForm" form
• added btn-default styles to Save Changes btn
• added btn-link styles to Cancel btn
• fixed info msg to display passwdReset.successSubmit.tip bundle text with emailAddress param in msg block and not on page (reverted this changed, and will add it, along with other UI/UX issues to Password Reset request throws NPE if email is not in authenticateduser table - v4.9.4 #5462)
• added btn-default styles to Reset Password btn

DASHBOARD

dashboard-datamove

• added p:focus component for "sourceDatasetMenu" p:autoComplete component in "datamove-form"
• changed p:commandLink component to p:commandButton for Save Changes btn in "datamove-form"
• changed Cancel btn styles from btn-default to btn-link in "datamove-form"
• changed h:commandButton component to p:commandButton for Yes btn in "datamoveConfirmation" popup (to resolve NetBeans warnings reported by Akio), as a result refactored update attribute values and added partialSubmit="true" attribute
• changed No btn styles from btn-default to btn-link, removed redundant, unnecessary value attribute

dashboard-users

• added p:focus component for "searchFiles" input field in "dashboardUsersForm"
• removed type="button" from p:commandButton Remove All btn in "dashboardUsersForm"
• added p:focus component for "toggleSuperuserConfirmation" popup
• changed Confirm and Cancel btn label text to Yes and No in "toggleSuperuserConfirmation" popup
• added modal="true" and closable="false" attributes to "removeRolesConfirm" popup
• changed p:commandButton component to generic html button No btn in "removeRolesConfirm" popup, added btn-link styles

harvestclients

• removed type="button" from p:commandLink Add Client btn in "harvestingClientsForm"
• removed type="button" from p:commandLink Run Harvesting btn in "harvestingClientsForm"
• removed type="button" from p:commandLink Edit btn in "harvestingClientsForm"
• removed type="button" from p:commandLink Delete btn in "harvestingClientsForm"
• added btn-default styles to Continue btn in "deleteConfirmation" popup
• added btn-link styles to Cancel btn in "deleteConfirmation" popup
• added p:focus component to "newHarvestingClientDialog"
• removed type="button" from p:commandLink Next btn (Step 1) in "newHarvestingClientDialog"
• removed type="button" from Cancel btn (Step 1), added btn-link styles, removed redundant, unnecessary value attribute
• removed type="button" from p:commandLink Previous btn (Step 2) in "newHarvestingClientDialog"
• removed type="button" from p:commandLink Next btn (Step 2) in "newHarvestingClientDialog"
• removed type="button" from Cancel btn (Step 2), added btn-link styles, removed redundant, unnecessary value attribute
• removed type="button" from p:commandLink Previous btn (Step 3) in "newHarvestingClientDialog"
• removed type="button" from p:commandLink Next btn (Step 3) in "newHarvestingClientDialog"
• removed type="button" from Cancel btn (Step 3), added btn-link styles, removed redundant, unnecessary value attribute
• removed type="button" from p:commandLink Create Client btn (Step 4) in "newHarvestingClientDialog"
• removed type="button" from p:commandLink Save Changes btn (Edit mode) in "newHarvestingClientDialog"
• changed Cancel btn (Step 4) styles from btn-default to btn-link in "newHarvestingClientDialog", removed redundant, unnecessary value attribute

harvestsets

• removed unnecessary rendered="#{true}" attribute from "harvestingSetsForm" h:form component
• removed type="button" from p:commandLink Add Set btn (empty table) in "harvestingSetsForm"
• removed type="button" from p:commandLink Add Set btn (not empty table) in "harvestingSetsForm"
• removed type="button" from p:commandLink Export btn in "harvestingSetsForm"
• removed type="button" from p:commandLink Edit btn in "harvestingSetsForm"
• removed type="button" from p:commandLink Delete btn in "harvestingSetsForm"
• added btn-default styles to Continue btn in "deleteConfirmation" popup
• added btn-link styles to Cancel btn in "deleteConfirmation" popup
• removed type="button" from p:commandLink Next btn (Step 1) in "newOAISetDialog"
• changed Cancel btn (Step 1) styles from btn-default to btn-link in "newOAISetDialog", removed redundant, unnecessary value attribute
• removed type="button" from p:commandLink Previous btn (Step 2) in "newOAISetDialog"
• removed type="button" from p:commandLink Create Set btn (Step 2) in "newOAISetDialog"
• removed type="button" from p:commandLink Save Changes btn (Edit mode) in "newOAISetDialog"
• changed Cancel btn (Step 2) styles from btn-default to btn-link in "newOAISetDialog", removed redundant, unnecessary value attribute

DATAVERSE

dataverse

• moved "Filter Results" btn (only in responsive display in small browsers for collapsed view of facets) text to bundle
• changed Link btn from a element to button
• removed redundant, unnecessary value attribute from Close btn in "sharrre-widget" popup
• added btn-default styles to Save Changes btn in "dataverseForm" edit form
• added btn-link styles to Cancel btn in "dataverseForm" edit form
• added p:focus component for "featuredDataverseList" p:pickList component in "browseOptsForm" (Featured Dataverses) popup
• added btn-default styles to Save Changes btn in "browseOptsForm" (Featured Dataverses) popup
• changed p:commandButton component to generic html button Cancel btn in "browseOptsForm" (Featured Dataverses) popup, added btn-link styles
• changed p:commandButton component to generic html button Close btn in "browseOptsForm" (Featured Dataverses) popup (with no published dataverses), added btn-default styles
• added btn-default styles to Continue btn in "publishDvConfirm" popup
• changed p:commandButton component to generic html button Cancel btn in "publishDvConfirm" popup, added btn-link styles
• changed p:commandButton component to generic html button Cancel btn in "mayNotRelease" popup, added btn-link styles
• added btn-default styles to Continue btn in "deleteDvConfirm" popup
• changed p:commandButton component to generic html button Cancel btn in "deleteDvConfirm" popup, added btn-link styles
• added p:focus for "dvNameSelect" h:selectOneMenu component to "linkDataverseForm" popup
• added btn-default styles to Save Linked Dataverse btn in "linkDataverseForm" popup
• added btn-default styles to Save Linked Search btn in "linkDataverseForm" popup
• changed p:commandButton component to generic html button Cancel btn in "linkDataverseForm" popup, added btn-link styles
• added btn-default styles to Save Linked Dataverse btn in "linkDataverseForm" popup (with only one dataverse to link to)
• changed p:commandButton component to generic html button Cancel btn in "linkDataverseForm" popup (with only one dataverse to link to), added btn-link styles
• changed p:commandButton component to generic html button Close btn in "linkDataverseForm" popup (with no dataverse to link to), added btn-default styles
• added btn-default styles to Save Linked Dataverse btn in "resetModifications" popup
• changed p:commandButton component to generic html button Cancel btn in "resetModifications" popup, added btn-link styles

ThemeAndWidgets

• added p:focus for "themeRoot" h:selectBooleanCheckbox component in "themeWidgetsForm"
• changed Cancel btn styles from btn-default to btn-link

permissions-manage

• removed type="button" from p:commandLink Edit Access btn in Permissions panel in "rolesPermissionsForm"
• removed type="button" from p:commandLink Assign Roles to Users/Groups btn in "rolesPermissionsForm"
• removed type="button" from p:commandLink Remove Assigned Role btn in "rolesPermissionsForm"
• removed type="button" from p:commandLink Add New Role btn in "rolesPermissionsForm"
• added p:focus component to "accessDialog" popup
• changed p:commandLink component to p:commandButton for Save Changes btn in "accessDialog" popup
• changed Cancel btn styles from btn-default to btn-link in "accessDialog" popup, removed redundant, unnecessary value attribute
• changed Cancel btn styles from btn-default to btn-link in "accessRemoveConfirm" popup, removed redundant, unnecessary value attribute
• added p:focus component to "userGroupDialog" popup
• changed text-danger style class to text-warning for message text in "userGroupDialog"
• changed p:commandLink component to p:commandButton for Save Changes btn in "userGroupDialog" popup
• changed Cancel btn styles from btn-default to btn-link in "userGroupDialog" popup, removed redundant, unnecessary value attribute
• changed Cancel btn styles from btn-default to btn-link in "confirmFileDownloader" popup, removed redundant, unnecessary value attribute
• added p:focus component to "userGroupDialog" popup
• changed styles of containing div to clean up responsive layout
• added p:focus component to "rolesPermissionsDialog" popup
• changed p:commandLink component to p:commandButton for Save Changes btn in "rolesPermissionsDialog" popup, removed type="button"
• changed Cancel btn styles from btn-default to btn-link in "rolesPermissionsDialog" popup, unnecessary value attribute

manage-groups

• removed type="button" from p:commandLink Create Group btn in "manageGroupsForm"
• removed type="button" from p:commandLink Edit btn in "manageGroupsForm"
• removed type="button" from p:commandLink Delete btn in "manageGroupsForm"
• added btn-default styles to Continue btn in "deleteGroupConfirm" popup
• removed type="button" from p:commandLink Cancel btn in "deleteGroupConfirm" popup, added btn-link styles
• added p:focus component to "viewGroup" popup
• removed type="button" from p:commandLink Delete btn in "viewGroup" popup, added btn-link styles
• removed type="button" from p:commandButton Save Changes btn in "viewGroup" popup
• changed p:commandButton component to generic html button Cancel btn in "viewGroup" popup, added btn-link styles
• changed p:commandLink component to p:commandButton for Save Changes btn in "explicitGroupNewDialog" popup, removed type="button"
• added btn-link styles to Cancel btn in "explicitGroupNewDialog" popup, removed redundant, unnecessary value attribute
• ignored known refresh bugs reported in Create Group: After adding a group for the first time, there is a success message but the welcome page needs to be refreshed to see group added. #2930, Groups UI: Delete user, then cancel or X the popup appears to delete user anyway but it is a refresh issue. #2413

manage-templates

• removed type="button" from h:outputLink Create Dataset Template btn in "manageTemplatesForm"
• removed type="button" from p:commandLink Make Default btn in "manageTemplatesForm", removed redundant bind_tooltip_popover(); from oncomplete attribute
• removed type="button" from p:commandLink Default btn in "manageTemplatesForm", removed redundant bind_tooltip_popover(); from oncomplete attribute
• removed type="button" from p:commandLink View btn in "manageTemplatesForm", removed redundant bind_tooltip_popover(); from oncomplete attribute
• removed type="button" from p:commandLink Copy btn in "manageTemplatesForm", removed redundant bind_tooltip_popover(); from oncomplete attribute
• removed type="button" from p:commandLink Delete btn in "manageTemplatesForm", removed redundant bind_tooltip_popover(); from oncomplete attribute
• changed text-danger style class to text-warning for message text in "deleteTemplateConfirm" popup
• added btn-default styles to Continue btn in "deleteTemplateConfirm" popup
• changed p:commandButton component to generic html button Cancel btn in "deleteTemplateConfirm" popup, added btn-link styles
• changed p:commandButton component to generic html button Close btn in "viewTemplate" popup

template

• added p:focus component for "templateForm"
• refactored #{TemplatePage.editMode == ...} render logic on p:commandButton components in "templateForm", removed unnecessary ui:fragment with redunant render logic
• added btn-link styles to Cancel btn in "templateForm", added btn-link styles

manage-guestbooks

• removed type="button" from h:outputLink Create Dataset Guestbook btn in "manageGuestbooksForm"
• removed type="button" from p:commandLink Enable btn in "manageGuestbooksForm", changed oncomplete="bind_tooltip_popover();" to oncomplete="bind_bsui_components();"
• removed type="button" from p:commandLink Disable btn in "manageGuestbooksForm", changed oncomplete="bind_tooltip_popover();" to oncomplete="bind_bsui_components();"
• removed type="button" from p:commandLink View btn in "manageGuestbooksForm"
• removed type="button" from h:outputLink Copy btn in "manageGuestbooksForm"
• removed type="button" from h:outputLink Edit btn in "manageGuestbooksForm"
• removed type="button" from p:commandLink Delete btn in "manageGuestbooksForm"
• added btn-default styles to Continue btn in "deleteGuestbookConfirm" popup
• changed p:commandButton component to generic html button Cancel btn in "deleteGuestbookConfirm" popup, added btn-link styles
• changed p:commandButton component to generic html button Close btn in "previewGuestbook" popup

guestbook

• added p:focus component for "guestbookForm"
• fixed styleClass attribute format for Save Changes btn in "guestbookForm"
• changed Cancel btn styles from btn-default to btn-link in "guestbookForm"

advanced

• added btn-default styles to both Find btn's in "advancedSearchForm"

DATASET

dataset
(EDIT mode)

• added p:focus component to "datasetForm"
• removed tabindex attribute from p:inputText component in "datasetForm"
• removed tabindex attribute from p:inputTextarea component in "datasetForm"
• removed tabindex attribute from p:inputTextarea Add "Replication Data for" to Title btn in "datasetForm"
• removed tabindex attribute from p:commandLink Add btn in "datasetForm" (datasetFieldType.allowMultiples render)
• removed tabindex attribute from p:commandLink Delete btn in "datasetForm" (datasetFieldType.allowMultiples render)
• removed tabindex attribute from p:selectOneMenu component in "datasetForm", removed random SELECT TESTTEST styles (single field)
• removed tabindex attribute from p:selectManyCheckbox component in "datasetForm" (single field)
• removed tabindex attribute from p:selectOneMenu component in "datasetForm", removed random SELECT TESTTEST styles (compound field)
• removed tabindex attribute from p:selectManyCheckbox component in "datasetForm" (compound field)
• removed tabindex attribute from p:selectOneMenu component in "datasetForm" (controlled vocab field)
  removed tabindex attribute from p:selectManyCheckbox component in "datasetForm" (controlled vocab field)
• added btn-default styles to Save Changes btn in "datasetForm", removed tabindex attribute
• added btn-link styles to Cancel btn in "datasetForm", removed tabindex attribute
• added btn-link styles to Cancel btn in "datasetForm", removed tabindex attribute (CREATE mode)
• removed tabindex attribute from p:commandLink Add btn in "datasetForm" (controlled vocab field)
• removed tabindex attribute from p:commandLink Delete btn in "datasetForm" (controlled vocab field)

(alert msg block)

• fixed "Validation Error" error alert msg format (to remove trailing hyphen) in "datasetForm"
• fixed "Unpublished Dataset Private URL" info alert msg format (Admin render)
• changed info format to warning for "Unpublished Dataset Private URL" alert msg, fixed label-msg format (Reviewer render)
• added "File Access" label to fix warning alert msg format ("publicly accessible storage server" render)

(VIEW mode)

• removed type="button" from p:commandLink Publish btn in "datasetForm" (unpublished render)
• removed type="button" from p:commandLink Publish btn in "datasetForm" (published render)
• removed type="button" from p:commandLink Publish btn in "datasetForm" (may not published render)
• removed type="button" from p:commandLink Publish btn in "datasetForm" (dataverse unpublished, publish partent render)
• removed type="button" from p:commandLink Publish btn in "datasetForm" (dataverse unpublished, may not published render)
• changed p:commandLink component to generic html button Return to Author btn in "datasetForm"
• removed ui:fragment and moved render logic to button Submit for Review/Submitted For Review btn in "datasetForm"
• removed type="button" from p:commandLink Link btn in "datasetForm"
• removed redundant, unnecessary value attribute from Close btn in "shareDialog"
• removed type="button" from p:commandLink Add + Edit Metadata btn in "datasetForm" (metadata tab)
• fixed class attribute format for Export Metadata btn in "datasetForm" (metadata tab)
• changed p:commandButton component to generic html button Close btn in "downloadInvalid" popup, added btn-default styles
• removed ui:fragment and moved render logic to button Continue btn's (with and without rsync render) in "downloadMixed" popup added btn-default styles
• changed p:commandButton component to generic html button Cancel btn in "downloadMixed" popup, added btn-default styles
• added btn-default styles to Save Changes btn in "deleteConfirmation" popup
• changed p:commandButton component to generic html button Cancel btn in "deleteConfirmation" popup, added btn-link styles
• added btn-default styles to Save Changes btn in "deleteVersionConfirmation" popup
• changed p:commandButton component to generic html button Cancel btn in "deleteVersionConfirmation" popup, added btn-link styles
• changed p:commandButton component to generic html button Cancel btn in "privateUrlId" popup, added btn-link styles
• changed p:commandButton component to generic html button Cancel btn in "privateUrlId" popup (!userCanCreatePrivateURL render), added btn-link styles
• changed p:commandButton component to generic html button Cancel btn in "disablePrivateUrlConfirmation" popup, added btn-link styles
• added btn-default styles to Save Changes btn in "deleteSelectedFileConfirmation" popup
• changed p:commandButton component to generic html button Cancel btn in "deleteSelectedFileConfirmation" popup, added btn-link styles
• changed p:commandButton component to generic html button Close btn in "computeInvalid" popup
• changed itemValue="0" to itemValue="#{null}" in p:selectOneMenu component in "deaccessionBlock" popup to fix display of requiredMessage from bundle
• changed p:commandLink component to p:commandButton for Deaccession btn in "deaccessionBlock" popup
• changed p:commandLink component to p:commandButton for Cancel btn in "deaccessionBlock" popup, added btn-link styles
• changed No btn styles from btn-default to btn-link in "deaccessionConfirmation", removed redundant, unnecessary value attribute
• changed No btn styles from btn-default to btn-link in "deaccessionAllConfirmation", removed redundant, unnecessary value attribute
• removed "selectDeaccessionVersion" p:confirmDialog that is no longer in use
• removed "selectDeaccessionReason" p:confirmDialog that is no longer in use
• removed "enterForwardUrl" p:confirmDialog that is no longer in use
• removed "enterOtherReason" p:confirmDialog that is no longer in use
• removed "reasonTooManyCharacters" p:confirmDialog that is no longer in use
• changed p:commandButton component to generic html button Close btn in "compareTwo" popup (versions tab)
• changed p:commandButton component to generic html button Done btn in "detailsBlocks" popup (versions tab)
• changed p:commandButton component to generic html button Close btn in "selectFilesForDownload" popup (files tab)
• changed p:commandButton component to generic html button Close btn in "selectFilesForRequestAccess" popup (files tab)
• changed p:commandButton component to generic html button Close btn in "selectFilesForDelete" popup (files tab)
• changed p:commandButton component to generic html button Close btn in "selectFilesForRestrict" popup (files tab)
• changed p:commandButton component to generic html button Close btn in "selectFilesForUnRestrict" popup (files tab)
• changed p:commandButton component to generic html button Close btn in "selectFilesForEditMetadata" popup (files tab)
• changed p:commandButton component to generic html button Close btn in "selectFilesForEditTags" popup (files tab)
• added p:focus component for "fileTagsMenuDS" p:selectCheckboxMenu component to "fileTagsPopup" popup (files tab)
• changed p:commandLink component to p:commandButton for Apply btn in "fileTagsPopup" (files tab)
• changed Cancel btn styles from btn-default to btn-link in "fileTagsPopup" (files tab)
• changed p:commandButton component to generic html button Close btn in "accessSignUpLogIn" popup (files tab)
• changed p:commandLink component to p:commandButton for Save Linked Dataset btn in "linkDatasetForm" popup
• changed Cancel btn styles from btn-default to btn-link in "linkDatasetForm" popup
• changed p:commandLink component to p:commandButton for Clear Batch btn in "computeBatchListPopup"
• changed h:commandButton component to generic html button Cancel btn in "computeBatchListPopup", added btn-link styles
• added p:focus component for "termsAccessInput" p:inputTextarea component to "accessPopup" (files tab)
• removed ui:fragment and moved render logic to p:commandButton Continue btn's in "accessPopup" (files tab)
• added btn-default styles to Continue btn's in "accessPopup" (files tab)
• changed p:commandButton component to generic html button Cancel btn in "accessPopup" (files tab), added btn-link styles
• added btn-default styles to Submit btn in "inreview" popup
• changed p:commandButton component to generic html button Cancel btn in "inreview" popup, added btn-link styles
• added btn-default styles to Continue btn in "publishConfirm" popup
• changed p:commandButton component to generic html button Cancel btn in "publishConfirm" popup, added btn-link styles
• added btn-default styles to Yes, Publish Both btn in "publishParent" popup
• changed p:commandButton component to generic html button Cancel btn in "publishParent" popup, added btn-link styles
• added btn-default styles to Continue btn's in "releaseDraft" popup
• changed p:commandButton component to generic html button Cancel btn in "releaseDraft" popup, added btn-link styles
• changed p:commandButton component to generic html button Close btn in "mayNotRelease" popup, added btn-default styles
• changed p:commandButton component to generic html button Close btn in "maynotPublishParent" popup, added btn-default styles
• added btn-default styles to Continue btn's in "sendBackToContributor" popup
• changed p:commandButton component to generic html button Cancel btn in "sendBackToContributor" popup, added btn-link styles
• removed "enterReturnReason" p:confirmDialog that is no longer in use, as well as related javascript function (left a FIXME comment in the code explaining all this)

(filesFragment)

• removed type="button" from h:outputLink Upload Files btn in "datasetForm" (Files tab)
• removed type="button" from p:commandLink Download btn in "datasetForm" (Files tab)
• removed type="button" from p:commandLink Download (guestbook/terms render) btn in "datasetForm" (Files tab)
• removed type="button" from p:commandLink Request Access btn (multiple, render) in "datasetForm" (Files tab)
• removed type="button" from p:commandLink Request Access btn (multiple, sign up req'd render) in "datasetForm" (Files tab)

(file-configure-popup-fragment)

• changed p:commandLink component to p:commandButton for Continue btn in "configureToolPopup" popup, removed type="button"

(file-download-button-fragment)

• removed type="button" from h:outputLink Compute btn in "datasetForm" (Files tab)
• removed type="button" from h:outputLink Compute btn in "datasetForm" (Files pg)
• removed type="button" from p:commandLink Download btn (package file render) in "datasetForm" (Files tab)
• removed type="button" from p:commandLink Download btn (package file, guestbook/terms render) in "datasetForm" (Files tab)
• removed type="button" from p:commandLink Download btn (not tabluar) in "datasetForm" (Files tab)
• removed type="button" from p:commandLink Download btn (not tabluar, guestbook/terms render) in "datasetForm" (Files tab)
• removed type="button" from p:commandLink Request Access btn in "datasetForm" (Files tab)
• removed type="button" from p:commandLink Request Access btn (guestbook/terms render) in "datasetForm" (Files tab)
• removed type="button" from p:commandLink Request Access btn (sign up render) in "datasetForm" (Files tab)

(file-download-popup-fragment)

• added p:focus component to "downloadPopup"
• changed p:commandLink component to p:commandButton Accept Terms btn in "downloadPopup" (Files tab), removed type="button"
• changed p:commandLink component to p:commandButton Accept Terms btn (subset render) in "downloadPopup" (Files tab), removed type="button"
• changed p:commandLink component to p:commandButton Accept Terms btn (worldmap render) in "downloadPopup" (Files tab), removed type="button"
• changed p:commandLink component to p:commandButton Accept Terms btn (externalTool render) in "downloadPopup" (Files tab), removed type="button"
• changed p:commandLink component to p:commandButton Accept Terms btn (package render) in "downloadPopup" (Files tab), removed type="button"
• changed Cancel btn styles from btn-default to btn-link in "datasetForm", removed redundant, unnecessary value attribute

(file-request-access-popup-fragment)

• changed p:commandLink component to p:commandButton Accept Terms btn in "downloadPopup" (Files tab), removed type="button"

(dataset-versions)

• changed p:commandLink to generic html button View Differences btn in "datasetForm" (Versions tab), removed type="button"

editdatafiles

• changed p:commandButton component to generic html button Save Changes btn in "datasetForm", removed tabindex attribute
• changed Cancel btn styles from btn-default to btn-link in "datasetForm", removed tabindex attribute
• added btn-default styles to Done btn in "datasetForm" (no file uploaded), removed tabindex attribute
• added btn-default styles to Delete btn in "fileTypeDifferentPopup"
• changed p:commandButton component to generic html button Continue btn in "fileTypeDifferentPopup", added btn-default styles
• changed p:commandButton component to generic html button Close btn in "selectFilesForDeleteFragment" popup, added btn-default styles
• added btn-default styles to Continue btn in "deleteFileConfirmDialog"
• changed p:commandButton component to generic html button Cancel btn in "deleteFileConfirmDialog", added btn-link styles
• removed unnecessary ui:fragment componet with !datasetPage render (x2 for both form elements) from "editFileAccessPopup"
• removed unnecessary ui:fragment componet with datasetPage render plus all contents (x2 for both form elements) from "editFileAccessPopup"
• added btn-default styles to Continue btn in "editFileAccessPopup", removed unnecessary !datasetPage render
• removed unnecessary p:commandButton component with datasetPage render from "editFileAccessPopup"
• changed p:commandButton component to generic html button Cancel btn in "editFileAccessPopup", added btn-link styles
• added p:focus component to "fileAdvancedOptions" popup
• added btn-default styles to Save Changes btn in "fileAdvancedOptions" popup
• added btn-link styles to Cancel btn in "fileAdvancedOptions" popup
• added p:focus component to "fileSetThumbnail" popup
• added btn-default styles to Save Changes btn in "fileSetThumbnail" popup
• added btn-link styles to Cancel btn in "fileSetThumbnail" popup
• added btn-default styles to Save Changes btn in "fileThumbnailConfirm" popup
• changed p:commandButton component to generic html button Cancel btn in "fileThumbnailConfirm" popup, added btn-link styles
• changed Cancel btn styles from btn-default to btn-link in "editProvenancePopup"
• changed p:commandButton component to generic html button Cancel btn in "editProvenancePopup" popup, added btn-link styles
• added p:focus component to "editFileTagsPopup"
• changed p:commandLink component to p:commandButton for Apply btn in "editFileTagsPopup"
• changed Cancel btn styles from btn-default to btn-link in "editFileTagsPopup"

dataset-license-terms
(VIEW mode, dataset pg)

• removed type="button" from p:commandLink Edit Terms Requirements btn in "datasetForm"
• changed p:commandLink component to p:commandButton for Preview Guestbook btn in "datasetForm" (Guestbook panel), removed type="button"

(EDIT mode)

• added btn-default styles to Clear Selection btn in "datasetForm" (Guestbook panel)
• rermoved unnecessary rendered="true" logic from p:column component in "datasetForm"
• changed p:commandLink component to p:commandButton for Preview Guestbook btn in "datasetForm" (Guestbook panel), removed type="button"
• changed Cancel btn styles from btn-default to btn-link in "previewGuestbook" popup, removed redundant, unnecessary value attribute

permissions-manage-files

• removed type="button" from p:commandLink Grant Access to Users/Groups btn in Permissions panel in "rolesPermissionsForm"
• removed type="button" from p:commandLink Files btn in "rolesPermissionsForm" (Requests table)
• removed type="button" from p:commandLink Grant btn in "rolesPermissionsForm" (Requests table)
• removed type="button" from p:commandLink Reject btn in "rolesPermissionsForm" (Requests table)
• removed type="button" from p:commandLink Files btn in "rolesPermissionsForm"
• removed type="button" from p:commandLink Remove Access btn in "rolesPermissionsForm"
• removed type="button" from p:commandLink Ussrs/Groups btn in "rolesPermissionsForm" (Files panel)
• removed type="button" from p:commandLink Assign Access btn in "rolesPermissionsForm" (Files panel)
• removed type="button" from p:commandLink Remove Access btn in "viewRemoveDialog"
• changed Cancel btn styles from btn-default to btn-link in "viewRemoveDialog", removed redundant, unnecessary value attribute
• added p:focus component to "accessDialog"
• removed type="button" from p:commandLink Grant btn in "assignDialog"
• removed type="button" from p:commandLink Grant btn (!empty fileRequester render) in "assignDialog"
• removed type="button" from p:commandLink Reject btn in "assignDialog"
• changed Cancel btn styles from btn-default to btn-link in "accessDialog" popup, removed redundant, unnecessary value attribute
• changed text-danger style class to text-warning for message text in "accessFileRemoveConfirm" popup
• added btn-default styles to Continue btn in "accessFileRemoveConfirm" popup
• changed p:commandButton component to generic html button Cancel btn in "accessFileRemoveConfirm" popup, added btn-link styles

dataset-widgets

• changed update="@all" to update="@form" for Remove, Save Changes, Cancel, Continue, btn's and p:fileUpload component to resolve CSS/plain text page flash on refresh
• changed text-danger style class to text-warning for message text in "confrmRemove" popup
• changed p:commandLink component to p:commandButton for Continue btn in "confrmRemove" popup
• changed Cancel btn styles from btn-default to btn-link in "confrmRemove" popup
• changed p:commandLink component to p:commandButton for Continue btn in "selectFileThumbnail" popup
• changed Cancel btn styles from btn-default to btn-link in "selectFileThumbnail" popup

FILE

file

• removed redundant, unnecessary value attribute from Close btn in "shareDialog"
• changed p:commandLink component to generic html button Edit btn in "fileForm" (if fileAlreadyReplacedDraft)
• fixed class attribute format for Export Metadata btn in "fileForm"
• added btn-default styles to Delete btn in "deleteFileConfirm" popup
• changed p:commandButton component to generic html button Cancel btn in "deleteFileConfirm" popup, added btn-link styles
• changed p:commandButton component to generic html button Close btn in "accessGuest" popup
• added p:focus component to "accessPopup"
• rermoved unnecessary ui:fragment component with rendered="true" logic in "accessPopup" popup
• added btn-default styles to Continue btn in "accessPopup" popup
• changed p:commandButton component to generic html button Cancel btn in "accessPopup" popup, added btn-link styles
• changed p:commandButton component to generic html button Close btn in "fileAlreadyReplacedDraft" popup
• changed p:commandButton component to generic html button Close btn in "fileAlreadyReplacedPrevious" popup
• changed p:commandButton component to generic html button Close btn in "computeAccessDenied" popup
• removed type="button" from p:commandLink View Differences btn in "fileForm"

[coveralls]

Coverage increased (+0.07%) to 19.694% when pulling 5314fbc on 5717-dialog-input-focus into 91ebe60 on develop.

[pdurbin]

As I said at #5717 (comment) I don't see anything obviously wrong in this (large) pull request but thankfully @mheppler has provided a detailed list of what to test!