Skip to content

Fix support protocol http import OAI_DC#8665

Merged
kcondon merged 4 commits intoIQSS:developfrom
Esteban-Mtz:7808-support-protocol-http
Jul 13, 2022
Merged

Fix support protocol http import OAI_DC#8665
kcondon merged 4 commits intoIQSS:developfrom
Esteban-Mtz:7808-support-protocol-http

Conversation

@Esteban-Mtz
Copy link
Contributor

@Esteban-Mtz Esteban-Mtz commented Apr 29, 2022

What this PR does / why we need it: Support identifiers like "http://hdl.handle.net/" or "http://doi.org/" on import OAI_DC

Which issue(s) this PR closes:

Suggestions on how to test this: No functional changes.

@pdurbin pdurbin self-assigned this May 23, 2022
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine and we have internal agreement that we're ok importing non-https DOI/HDL URLs.

I added some unit tests but I didn't deploy the code.

I'm not sure the best way to QA this. @Esteban-Mtz do you have a server set up that @kcondon can harvest from?

My understanding is there are two places where the newly supported URLs can appear:

  • primary identifier
  • other id

@pdurbin pdurbin removed their assignment Jun 8, 2022
@kcondon kcondon self-assigned this Jun 8, 2022
@kcondon
Copy link
Contributor

kcondon commented Jun 23, 2022

Hi @Esteban-Mtz , I'm ready to test this but it needs to be refreshed from the develop branch since we have just made a new release and the version numbers were incremented. Regards, Kevin

@kcondon kcondon removed their assignment Jul 11, 2022
@kcondon
Copy link
Contributor

kcondon commented Jul 12, 2022

@Esteban-Mtz Would you refresh this from the develop branch so I can test this? Thanks, Kevin

@kcondon kcondon self-assigned this Jul 12, 2022
@pdurbin
Copy link
Member

pdurbin commented Jul 13, 2022

@kcondon @Esteban-Mtz I just merged the latest from the "develop" branch into this pull request.

@Esteban-Mtz
Copy link
Contributor Author

Thanks everyone!! Sorry for not replying sooner. I had my daughter in June and I have been on leave until today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not support protocol "http" on method reassignIdentifierAsGlobalId

3 participants