Fix support protocol http import OAI_DC#8665
Conversation
pdurbin
left a comment
There was a problem hiding this comment.
The code looks fine and we have internal agreement that we're ok importing non-https DOI/HDL URLs.
I added some unit tests but I didn't deploy the code.
I'm not sure the best way to QA this. @Esteban-Mtz do you have a server set up that @kcondon can harvest from?
My understanding is there are two places where the newly supported URLs can appear:
- primary identifier
- other id
|
Hi @Esteban-Mtz , I'm ready to test this but it needs to be refreshed from the develop branch since we have just made a new release and the version numbers were incremented. Regards, Kevin |
|
@Esteban-Mtz Would you refresh this from the develop branch so I can test this? Thanks, Kevin |
|
@kcondon @Esteban-Mtz I just merged the latest from the "develop" branch into this pull request. |
|
Thanks everyone!! Sorry for not replying sooner. I had my daughter in June and I have been on leave until today. |
What this PR does / why we need it: Support identifiers like "http://hdl.handle.net/" or "http://doi.org/" on import OAI_DC
Which issue(s) this PR closes:
Suggestions on how to test this: No functional changes.