Skip to content

Add support for dx.doi.org#8866

Merged
kcondon merged 3 commits intoIQSS:developfrom
tcoupin:harversting-dxdoiorg
Aug 4, 2022
Merged

Add support for dx.doi.org#8866
kcondon merged 3 commits intoIQSS:developfrom
tcoupin:harversting-dxdoiorg

Conversation

@tcoupin
Copy link
Member

@tcoupin tcoupin commented Jul 29, 2022

What this PR does / why we need it: Support identifiers like "https://dx.doi.org/" or "http://dx.doi.org/" on import OAI_DC

See #8738 and #8665

[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.017 s - in edu.harvard.iq.dataverse.api.imports.ImportGenericServiceBeanTest

@coveralls
Copy link

coveralls commented Jul 29, 2022

Coverage Status

Coverage increased (+0.002%) to 19.729% when pulling 94d54a6 on tcoupin:harversting-dxdoiorg into af22d3f on IQSS:develop.

@tcoupin tcoupin marked this pull request as ready for review July 29, 2022 09:01
@tcoupin tcoupin force-pushed the harversting-dxdoiorg branch from 17f19dc to ddd3ecb Compare July 29, 2022 10:24
@pdurbin pdurbin self-assigned this Aug 1, 2022
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged the latest (5.11.1, etc.) into this PR and made sure the API tests are passing.

The change is morally equivalent to the one at PR #8665 which the team was ok with.

I'm not sure how to test this. Perhaps @tcoupin can provide a URL to an OAI server with "dx" identifiers that we can try to harvest from.

Also, perhaps in the future we should update doc/sphinx-guides/source/admin/harvestclients.rst to list the identifier formats we support in the harvesting clients.

Anyway, approved. Thanks, @tcoupin!

@pdurbin pdurbin removed their assignment Aug 3, 2022
@tcoupin
Copy link
Member Author

tcoupin commented Aug 4, 2022 via email

@kcondon kcondon self-assigned this Aug 4, 2022
@kcondon kcondon merged commit 5dfc151 into IQSS:develop Aug 4, 2022
@pdurbin pdurbin added this to the 5.12 milestone Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants