Merged
Conversation
17f19dc to
ddd3ecb
Compare
pdurbin
approved these changes
Aug 3, 2022
Member
pdurbin
left a comment
There was a problem hiding this comment.
I merged the latest (5.11.1, etc.) into this PR and made sure the API tests are passing.
The change is morally equivalent to the one at PR #8665 which the team was ok with.
I'm not sure how to test this. Perhaps @tcoupin can provide a URL to an OAI server with "dx" identifiers that we can try to harvest from.
Also, perhaps in the future we should update doc/sphinx-guides/source/admin/harvestclients.rst to list the identifier formats we support in the harvesting clients.
Anyway, approved. Thanks, @tcoupin!
Member
Author
|
Hi,
You can try dataverse.cirad.fr, there are dx identifiers in the IRD_author set
3 août 2022 21:04:11 Philip Durbin ***@***.***>:
… ***@***.**** approved this pull request.
I merged the latest (5.11.1, etc.) into this PR and made sure the API tests are passing.
The change is morally equivalent to the one at PR #8665[#8665] which the team was ok with.
I'm not sure how to test this. Perhaps @tcoupin[https://github.com/tcoupin] can provide a URL to an OAI server with "dx" identifiers that we can try to harvest from.
Also, perhaps in the future we should update *doc/sphinx-guides/source/admin/harvestclients.rst* to list the identifier formats we support in the harvesting clients.
Anyway, approved. Thanks, @tcoupin[https://github.com/tcoupin]!
—
Reply to this email directly, view it on GitHub[#8866 (review)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ABY4U2UQ2UMIRIYHCWRTNTLVXK7CPANCNFSM5476XYZQ].
You are receiving this because you were mentioned.[Image de pistage][https://github.com/notifications/beacon/ABY4U2SMDS5ODLA6LVR573DVXK7CPA5CNFSM5476XYZ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOH45XOLQ.gif]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Support identifiers like "https://dx.doi.org/" or "http://dx.doi.org/" on import OAI_DC
See #8738 and #8665
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.017 s - in edu.harvard.iq.dataverse.api.imports.ImportGenericServiceBeanTest