Skip to content

Harvest: support dx.doi.org url and http protocol#8738

Closed
tcoupin wants to merge 1 commit intoIQSS:developfrom
tcoupin:harvest-dxdoiorg-and-http
Closed

Harvest: support dx.doi.org url and http protocol#8738
tcoupin wants to merge 1 commit intoIQSS:developfrom
tcoupin:harvest-dxdoiorg-and-http

Conversation

@tcoupin
Copy link
Member

@tcoupin tcoupin commented May 25, 2022

What this PR does / why we need it:

Currently, surported global id formats are:

This PR add support for:

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 19.239% when pulling 46f2b12 on tcoupin:harvest-dxdoiorg-and-http into f578a5e on IQSS:develop.

@pdurbin
Copy link
Member

pdurbin commented Jul 28, 2022

@tcoupin I noticed there are merged conflicts (probably due to use merging PR #8665). Can you please resolve them? Thanks!

@tcoupin
Copy link
Member Author

tcoupin commented Jul 28, 2022

This PR is now outdated since #8665 add support for http.
I will close this PR and open a new one based on work done by @kcondon in #8665

(keep this open until I create the new...)

@poikilotherm
Copy link
Contributor

Hey @tcoupin, this PR slipped through the cracks for me. This is very much related to my post to the Google Group.

As this is something we'd really need, I'd volunteer to help out if you want.

@tcoupin
Copy link
Member Author

tcoupin commented Jul 29, 2022

Thanks you @poikilotherm for your help.
@pdurbin I made this MR #8866

@tcoupin tcoupin closed this Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants