Skip to content

Comments

Payara 6 testing#9426

Closed
ErykKul wants to merge 491 commits intoIQSS:8305-payara6-ee10from
ErykKul:8305-payara6-ee10
Closed

Payara 6 testing#9426
ErykKul wants to merge 491 commits intoIQSS:8305-payara6-ee10from
ErykKul:8305-payara6-ee10

Conversation

@ErykKul
Copy link
Collaborator

@ErykKul ErykKul commented Mar 6, 2023

What this PR does / why we need it:
I was playing with Payara 6 and I had some tests failing. I have merged the develop branch on the 8305-payara6-ee10 branch, fixed some tests, done some library updates, etc.

In order to avoid double work, I thought that I will just share it. Note that two integration test are still failing due to the known issue with slf4j logging:
payara/Payara#6211
payara/Payara#5898

image

Special notes for your reviewer:
If it is more work to review it than the amount of work it saves, just reject it.
My commits:
image

Suggestions on how to test this:
Run the unit and integration tests; the build uses Payara 6 with jdk 17.

pdurbin and others added 30 commits January 11, 2023 17:43
…IQSS/9126-allow_workflow_tokens_in_access_api

IQSS/9126- Fix workflow token access
"Use a version like '4.11.0.1' in the example above where the
previously released version was 4.11" -- dev guide

That is, these scripts should have been 5.12.1.whatever since
the last release was 5.12.1. Fixing. (They were 5.13.whatever.)
extract metadata (NcML XML) from NetCDF/HDF5 files, new "requirements" option for external tools
@ErykKul
Copy link
Collaborator Author

ErykKul commented Mar 6, 2023

I had resource problem when building and running integration test, my disk was getting full quickly. I have solved it by adding docker system prune -a -f to the prep_it.bash script. Also, there was a problem with setting the URL with the seturl.bash. I have replaced the script by setting the values in microprofile-config.properties. It also set the dataverse.oai.server.maxidentifiers and dataverse.oai.server.maxrecords values as required by one of the integration tests.

@poikilotherm
Copy link
Contributor

Hi @ErykKul !

Thanks for putting so much work into this. Yet, this is a monster of a pull request as you moved in a lot of additional changes unrelated to moving to Payara 6 and the merge of the develop branch. It's simply too many parts moving at the same time, sorry!

I just updated the underlying branch to latest develop to reduce the noise. Would you be so kind to create small, distinct pull requests against the branch? That would help a lot in getting things reviewed and merged!

I had the impression you'd also try to move things towards Java 17. This happens in a different show over at #9291, as this is also a very valid goal still being on Payara 5. Would you be so kind to take a look at what things might be good to include there first? (That branch already had the update with REST assured and I saw you fixed a couple of code parts related to this.)

Again: thanks for sharing the efforts! Much appreciated!

@ErykKul ErykKul closed this Mar 24, 2023
@ErykKul ErykKul deleted the 8305-payara6-ee10 branch March 24, 2023 13:24
@ErykKul ErykKul restored the 8305-payara6-ee10 branch March 24, 2023 13:24
@ErykKul ErykKul deleted the 8305-payara6-ee10 branch March 24, 2023 13:24
@ErykKul ErykKul restored the 8305-payara6-ee10 branch March 24, 2023 13:24
@cmbz cmbz added this to the 6.0 milestone Jul 24, 2023
@cmbz cmbz added FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) and removed FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) labels Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.