Add more tests for FieldChange Class#8614
Merged
calixtus merged 5 commits intoJabRef:mainfrom Mar 31, 2022
Merged
Conversation
koppor
requested changes
Mar 28, 2022
Member
koppor
left a comment
koppor
left a comment
There was a problem hiding this comment.
Please replace assertTrue and assertFalse semantically (!) by assertEquals. I provided an example below.
koppor
added
the
status: changes-required
Contributor
Author
|
Thanks for review, I think the visualization is better now. |
koppor
approved these changes
Mar 28, 2022
Member
koppor
left a comment
koppor
left a comment
There was a problem hiding this comment.
Even though the CI shows failing unit tests, the failing tests are not related to these changes.
calixtus
approved these changes
Mar 31, 2022
Member
|
Thanks for your addition to our test suite. Are you interested in working on JabRef more? We would be happy to answer your questions in our gitter channel, if you like. |
Contributor
Author
|
thanks for the invitation, i'll keep contributing! |
Siedlerchr
added a commit
that referenced
this pull request
Apr 5, 2022
* upstream/main: Remove obsolete comments Improve key generation (#8641) Refine search code (#8636) Fix import entry by id does not generate citation key (#8361) Update Gradle Wrapper from 7.4.1 to 7.4.2. (#8637) Bump hmarr/auto-approve-action from 2.1.0 to 2.2.0 (#8638) GitBook: [#57] test Citation keygen: Return vonPart if lastName is empty (#8634) Ensure SSL truststore is present at startup (#8631) Squashed 'buildres/csl/csl-styles/' changes from 6a7b708..21e2177 (#8632) Add more tests for FieldChange Class (#8614)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description :
Testing using self equals method of class FieldChange