Ensure SSL truststore is present at startup#8631
Merged
calixtus merged 4 commits intoJabRef:mainfrom Apr 2, 2022
HoussemNasri:create-trusstore-at-startup
Merged
Ensure SSL truststore is present at startup#8631calixtus merged 4 commits intoJabRef:mainfrom HoussemNasri:create-trusstore-at-startup
calixtus merged 4 commits intoJabRef:mainfrom
HoussemNasri:create-trusstore-at-startup
Conversation
Siedlerchr
approved these changes
Apr 1, 2022
Siedlerchr
added
the
status: ready-for-review
Member
|
Just a general question: Does the trustsotre content change with the java version? I might guess that new certifacates are added or revoked. So we need to ensure that we always copy the jdk's truststore in our resources and maybe also merge? the contents when the store already exists from an older version? |
calixtus
approved these changes
Apr 2, 2022
Member
|
Thanks for the follow up! |
Member
Author
|
@Siedlerchr That is correct; in JDK 17 they removed Telia Company's Sonera Class2 CA Certificate and added 2 HARICA Root CA Certificates. Merging new JDK truststore is an option; it can be done in 3 steps:
JDK certificates alias follow a specific pattern, so we can filter them in to remove them. |
Member
|
Thanks for the explanation. Okay, this seems like it could be implemented as part of a migration process in JabRef. |
Siedlerchr
added a commit
that referenced
this pull request
Apr 5, 2022
* upstream/main: Remove obsolete comments Improve key generation (#8641) Refine search code (#8636) Fix import entry by id does not generate citation key (#8361) Update Gradle Wrapper from 7.4.1 to 7.4.2. (#8637) Bump hmarr/auto-approve-action from 2.1.0 to 2.2.0 (#8638) GitBook: [#57] test Citation keygen: Return vonPart if lastName is empty (#8634) Ensure SSL truststore is present at startup (#8631) Squashed 'buildres/csl/csl-styles/' changes from 6a7b708..21e2177 (#8632) Add more tests for FieldChange Class (#8614)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #8583.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)