Conversation
Member
Author
|
Side comment: The search rules contain logic;, thus, they could/should IMHO be moved from |
koppor
added
the
status: ready-for-review
calixtus
approved these changes
Apr 4, 2022
Member
calixtus
left a comment
calixtus
left a comment
There was a problem hiding this comment.
Spotted almost only some rewording. Looks good to me.
6 tasks
koppor
removed
the
status: ready-for-review
9 tasks
Siedlerchr
added a commit
that referenced
this pull request
Apr 5, 2022
* upstream/main: Remove obsolete comments Improve key generation (#8641) Refine search code (#8636) Fix import entry by id does not generate citation key (#8361) Update Gradle Wrapper from 7.4.1 to 7.4.2. (#8637) Bump hmarr/auto-approve-action from 2.1.0 to 2.2.0 (#8638) GitBook: [#57] test Citation keygen: Return vonPart if lastName is empty (#8634) Ensure SSL truststore is present at startup (#8631) Squashed 'buildres/csl/csl-styles/' changes from 6a7b708..21e2177 (#8632) Add more tests for FieldChange Class (#8614)
Siedlerchr
added a commit
that referenced
this pull request
Apr 5, 2022
…om.github.tomtung-latex2unicode_2.12-0.3.0 * upstream/main: Remove obsolete comments Improve key generation (#8641) Refine search code (#8636) Fix import entry by id does not generate citation key (#8361) Update Gradle Wrapper from 7.4.1 to 7.4.2. (#8637) Bump hmarr/auto-approve-action from 2.1.0 to 2.2.0 (#8638)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports refactoring commits of #8206 to here. These are the commits before I began to add support for Lucene.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)