Merged
Conversation
Contributor
|
This works, but not how I expected
How many seconds of images are being loaded? It looks like 5 ahead, plus a frame or two behind?
I'm testing on video now. |
subdavis
approved these changes
Nov 3, 2020
Contributor
subdavis
left a comment
subdavis
left a comment
There was a problem hiding this comment.
Video also works. Ran pipeline on video on viame.kitware.com and locally.
Broken in prod, works locally.
Collaborator
Author
There is a specification in the ImageAnnotator. By default it is 6 seconds total with a 90-10 split, 90% of the frames to the front, 10% of the frames behind. This update should force it to download the first frame initially, then start the caching. What you describe sounds about how it should work with 6 seconds forward and then 10% of the backwards (3 frames, but I probably include the current frame so 2) if they aren't loaded yet. Eventually it may make sense to do the standard continually loading frames in the background like a typical video would instead of this isolated sections. |
BryonLewis
pushed a commit
that referenced
this pull request
Nov 16, 2020
Update base image for girder worker Fixes FPS issue and image caching (#419) * fixing fps and modifying cache * mend Update docker docs (#379) Co-authored-by: Brandon Davis <git@subdavis.com> Update blank.yml (#415) Upgrade to node LTS Co-authored-by: Jacob Nesbitt <jjnesbitt2@gmail.com> Add checkbuild.sh (#425) Add load and save for JSON annotations (#414) * Add load and save for JSON annotations * Relax json file name requirement * SIP * Implement settings, sanity checks, separate loading of datasets * WIP * remove settings page Fix deploy.yml Update day strings (#430) Fix typo in library README Allow setting of arbitrary attributes on video player (#435) * Mute video prop * Allow setting arbitrary attributes Downgrade urllib3 (#439) Fix inverse interpolation (#433) Run pipelines enabled incorrectly (#441) Add dummy generators Very minor fixes
BryonLewis
added a commit
that referenced
this pull request
Nov 16, 2020
Trying to get the styling and layout setup Updating some styling Updated styling a bit and added toggling Started updating the editor and connecting it to the attributes endpoint Updating styling and fixing various issues mend mend Electron (#397) * add electron * Add missing api methods * Fix build errors for electron, add to CI * Address comments Update deploy to only Thursday Update base image for girder worker Fixes FPS issue and image caching (#419) * fixing fps and modifying cache * mend Update docker docs (#379) Co-authored-by: Brandon Davis <git@subdavis.com> Update blank.yml (#415) Upgrade to node LTS Co-authored-by: Jacob Nesbitt <jjnesbitt2@gmail.com> Add checkbuild.sh (#425) Add load and save for JSON annotations (#414) * Add load and save for JSON annotations * Relax json file name requirement * SIP * Implement settings, sanity checks, separate loading of datasets * WIP * remove settings page Fix deploy.yml Update day strings (#430) Fix typo in library README Allow setting of arbitrary attributes on video player (#435) * Mute video prop * Allow setting arbitrary attributes Downgrade urllib3 (#439) Fix inverse interpolation (#433) Run pipelines enabled incorrectly (#441) Minor fix to attributes Minor ui fixes Addressing changes Enable pinch zoom on mobile (#440) Co-authored-by: Brandon Davis <git@subdavis.com> Add dummy generators (#438) conversion to using api for attributes editing converted attribute editor and added in additional editing Updating UI interactions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #420
FPS fix - the FPS was automatically a number so it was failing in the computed property to return the proper value and was defaulting everything to 10.
Image Cache fix - The original image caching would cache 6 seconds of data initially for image sequences. This works for standard images but not for 16MB+ images. It's trying to load all 7 images (at 1 frame per second) without any order priority so the first image may be the last to load. I defaulted to loading the initial image first, then followed by caching so you can move through at least some images quickly and the system isn't sitting there doing nothing while you gawk at the first image.
Please test and make sure I didn't completely mess something up.