Throw exception when lsid is not found in table selector list #3227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
requested changes
Apr 6, 2022
| } | ||
| else | ||
| { | ||
| throw new NotFoundException("LSID value not found in table - " + table.getName()); |
Contributor
There was a problem hiding this comment.
NotFoundException is useful when the client set us a request for something that doesn't exist. We don't log it as an error because it was a bogus request.
IllegalStateException is a better fit here, as this represents something that shouldn't happen. It'll get logged and be more likely to be noticed with test failures.
Contributor
Author
There was a problem hiding this comment.
makes sense. changed.
labkey-jeckels
approved these changes
Apr 7, 2022
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
I know you're still tracking down test failures but the fact that this change exposed those problems is a good confirmation of the approach.
| import org.labkey.api.security.permissions.Permission; | ||
| import org.labkey.api.security.permissions.UpdatePermission; | ||
| import org.labkey.api.util.Pair; | ||
| import org.labkey.api.view.NotFoundException; |
Contributor
There was a problem hiding this comment.
This can be trimmed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
EHR billing tables have extensible columns and when those table rows are updated, the existing values for extensible columns get lost when lsid is not found in table selector.
Related Pull Requests