Merge WNPRC's wnprc21.3-SNAPSHOT to LabKey's release21.3-SNAPSHOT #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to revisit this
…lict with WNPRC_Purchasing dependendies
Epic 8218 : Purchasing System Module Admin Pages (#67)
…ee LK ticket 43894
Merge staging changes into prod
labkey-jeckels
changed the title
… child are the same
Only do the dam/sire vendor id swap if the species between parent and child are the same
…deprive window and organizing the metadata for drug administration
Various change to treatments and food deprive
Adding dataset definitions for water monitoring system.
Contributor
Author
|
Tests are now passing. |
labkey-bpatel
approved these changes
Oct 8, 2021
Contributor
labkey-bpatel
left a comment
labkey-bpatel
left a comment
There was a problem hiding this comment.
Looks good, couple comments:
- Water Request.js is an empty file
- wnprc-18.37-18.38.sql creates ehr_lookups.husbandry_frequency -
does this need to be part of ehr_lookups.xml?
Also, don't think it matters that much but just noticed that this script won't run for existing dev db since wnprc module v. is at 21.000
…ting code references Add missing columns in wnprc_compliance schema
Contributor
Author
|
@labkey-bpatel I fixed the problems with the WNPRC script modifying the ehr_lookups schema. Thanks for catching it! The empty file isn't great but shouldn't cause problems either so I left it as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Pull in WNPRC's 21.3 work from their repo into our fork