Mail translations 2nd attempt #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hakito
commented
Nov 2, 2024
hakito
commented
- Remove *-custom.tpl from repo - should only be provided by the user
- Ignore custom translation files
- defaultPath is a fallback path - The name is misleading, as it's not the default.language setting
- Remove dead code
- DisplayLocalized in SmartyPage was never called
- DisplayLocalized in Page was only a copy, which is still called, but the languageCode parameter is not used.
- Fix save custom email template for selected language - fixes Custom email templates saved for wrong language #424
- Fallback to default lang for missing custom templates ..but only when custom template is available for default lang.
- Add config description
- Change ReservationShareMail property name - It conflicts with the now protected email property
- Fix unit test for updating email template
- closes Limit languages for emails #416
* Remove *-custom.tpl from repo - should only be provided by the user * Ignore custom translation files * defaultPath is a fallback path - The name is misleading, as it's not the default.language setting * Remove dead code * DisplayLocalized in SmartyPage was never called * DisplayLocalized in Page was only a copy, which is still called, but the languageCode parameter is not used. * Fix save custom email template for selected language - fixes LibreBooking#424 * Fallback to default lang for missing custom templates ..but only when custom template is available for default lang. * Add config description * Change ReservationShareMail property name - It conflicts with the now protected email property * Fix unit test for updating email template * closes LibreBooking#416
hakito
force-pushed
the
mail-translations2
branch
from
f6d3799 to
507817e
Compare
Contributor
Author
|
@effgarces The revert in #441 removed also the changes for #416 and #424. So here is a PR only with the changes for the translations and no refactoring of the email system itself. I also considered the comment from lucs7 . The tests are currently failing because of #451 |
hakito
force-pushed
the
mail-translations2
branch
2 times, most recently
from
c32a876 to
507817e
Compare
Contributor
Author
|
Now checks are green after DST adaption in New York. (See #451) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.