style: make Git blame ignore specified large refactor and lint commits #30661

HowardBraham · 2025-03-01T00:37:11Z

Description

@davidmurdoch requested this feature here: #30440 (review)

Also adds to the VSCode GitLens settings. If a Cursor user could help with the Cursor settings, that would be much appreciated.

We should discuss:

The inclusion of Added storybook check to CI #17092, as I'm undecided about it
Whether it's appropriate to automatically execute git config blame.ignoreRevsFile .git-blame-ignore-revs in postinstall. It writes to the local .git/config file in your metamask-extension folder, so it's only changing that one folder.

Command to get commits with over 200 file changes

git log --pretty=format:"%H %s" --shortstat | awk '{if ($1 ~ /^[0-9]+$/) {num = $1 + 0; if (num > 200 && current_hash !~ /Revert/) print num " " current_hash} else current_hash = $0}' | sort -nr

Related issues

David Murdoch request: #30440 (review)

Ignored PRs

github-actions · 2025-03-01T00:37:27Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

davidmurdoch · 2025-03-01T01:05:50Z

package.json

    "webpack": "tsx ./development/webpack/launch.ts",
    "webpack:clearcache": "./development/clear-webpack-cache.js",
    "foundryup": "tsx ./test/helpers/foundry/foundryup.ts",
-    "postinstall": "yarn webpack:clearcache && yarn foundryup",


loose opinion: I think gitlens might be fine, but not postinstall for everyone

.git-blame-ignore-revs

metamaskbot · 2025-03-01T01:42:49Z

Builds ready [552198a]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1479 ± 40 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	548	1706	1443	221	106
		domContentLoaded	1369	1689	1460	79	38
		load	1373	1707	1479	82	40
		domInteractive	23	83	38	21	10
		backgroundConnect	10	68	27	15	7
		firstReactRender	14	63	27	20	9
		getState	4	53	13	15	7
		initialActions	0	1	0	0	0
		loadScripts	985	1223	1082	67	32
		setupStore	7	47	14	14	7
		uiStartup	1559	1917	1666	91	44

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

georgewrmarshall

This is great! TIL about .git-blame-ignore-revs :D No strong opinions but left one comment

georgewrmarshall · 2025-03-04T18:16:19Z

.git-blame-ignore-revs

+#17092 Added storybook check to CI @NidhiKJha
+#### Let's discuss if this one should be removed from the list
+c5368c152b544433a2087597f0cb36b33fbd9c6a


non-blocking: Not a strong opinion, but since this commit adds functionality for testing code changes against Storybook stories and is not purely aesthetic, we may want to remove it from the .git-blame-ignore-revs file.

Okay good, that's why I wrote "Let's discuss if this one should be removed from the list"

Removed now!

metamaskbot · 2025-03-04T21:00:55Z

Builds ready [559c57b]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1730 ± 69 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1496	2129	1728	145	70
		domContentLoaded	1486	2101	1707	141	68
		load	1498	2132	1730	143	69
		domInteractive	26	80	37	14	7
		backgroundConnect	11	70	24	17	8
		firstReactRender	15	73	32	22	10
		getState	5	59	24	22	11
		initialActions	0	44	2	10	5
		loadScripts	1103	1621	1275	121	58
		setupStore	8	63	15	16	8
		uiStartup	1667	2393	1966	153	74

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

georgewrmarshall

LGTM! Also tested in Cursor see slack thread

Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>

metamaskbot · 2025-03-05T09:28:00Z

Builds ready [b990a29]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1835 ± 123 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	322	2425	1577	573	275
		domContentLoaded	1471	2412	1805	256	123
		load	1479	2426	1835	256	123
		domInteractive	26	110	47	23	11
		backgroundConnect	10	70	34	20	10
		firstReactRender	14	77	37	22	11
		getState	5	69	18	19	9
		initialActions	0	1	0	0	0
		loadScripts	1110	1810	1367	211	101
		setupStore	7	69	18	17	8
		uiStartup	1659	2756	2085	294	141

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

davidmurdoch

i like it!

we can always remove these commits from the ignore file if someone complains. YOLO!

HowardBraham self-assigned this Mar 1, 2025

HowardBraham requested a review from davidmurdoch March 1, 2025 00:37

metamaskbot added the team-tiger-deprecated DEPRECATED: team no longer exists label Mar 1, 2025

HowardBraham requested review from Gudahtt, dbrans, georgewrmarshall and itsyoboieltr March 1, 2025 00:37

HowardBraham marked this pull request as ready for review March 1, 2025 00:57

davidmurdoch reviewed Mar 1, 2025

View reviewed changes

.git-blame-ignore-revs Outdated Show resolved Hide resolved

HowardBraham added team-extension-platform Extension Platform team and removed team-tiger-deprecated DEPRECATED: team no longer exists labels Mar 3, 2025

gauthierpetetin added this to PR review queue Mar 3, 2025

github-project-automation bot moved this to Needs dev review in PR review queue Mar 3, 2025

HowardBraham mentioned this pull request Mar 3, 2025

feat(ci): Add changed lines check MetaMask/github-tools#49

Merged

georgewrmarshall reviewed Mar 4, 2025

View reviewed changes

HowardBraham force-pushed the git-blame-ignore-revs branch from 06332f8 to 559c57b Compare March 4, 2025 20:27

HowardBraham requested review from davidmurdoch and georgewrmarshall March 4, 2025 20:27

HowardBraham enabled auto-merge March 4, 2025 21:07

georgewrmarshall approved these changes Mar 5, 2025

View reviewed changes

HowardBraham and others added 4 commits March 5, 2025 00:49

style: make Git blame ignore specified large refactor and lint commits

ac679f1

Update .git-blame-ignore-revs

dc5fd6c

Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>

Removed one SHA

b011009

removed the postinstall command

b990a29

HowardBraham force-pushed the git-blame-ignore-revs branch from 559c57b to b990a29 Compare March 5, 2025 08:49

davidmurdoch approved these changes Mar 5, 2025

View reviewed changes

HowardBraham added this pull request to the merge queue Mar 5, 2025

github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Mar 5, 2025

Merged via the queue into main with commit 3c6d268 Mar 5, 2025
74 checks passed

HowardBraham deleted the git-blame-ignore-revs branch March 5, 2025 16:04

github-actions bot locked and limited conversation to collaborators Mar 5, 2025

metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

style: make Git blame ignore specified large refactor and lint commits #30661

style: make Git blame ignore specified large refactor and lint commits #30661

Uh oh!

HowardBraham commented Mar 1, 2025 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Mar 1, 2025

Uh oh!

davidmurdoch Mar 1, 2025

Uh oh!

Uh oh!

metamaskbot commented Mar 1, 2025

Uh oh!

georgewrmarshall left a comment

Uh oh!

georgewrmarshall Mar 4, 2025 •

edited

Loading

Uh oh!

HowardBraham Mar 4, 2025

Uh oh!

metamaskbot commented Mar 4, 2025

Uh oh!

georgewrmarshall left a comment •

edited

Loading

Uh oh!

metamaskbot commented Mar 5, 2025

Uh oh!

davidmurdoch left a comment •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

style: make Git blame ignore specified large refactor and lint commits #30661

style: make Git blame ignore specified large refactor and lint commits #30661

Uh oh!

Conversation

HowardBraham commented Mar 1, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Ignored PRs

Uh oh!

github-actions bot commented Mar 1, 2025

Uh oh!

davidmurdoch Mar 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

metamaskbot commented Mar 1, 2025

Uh oh!

georgewrmarshall left a comment

Choose a reason for hiding this comment

Uh oh!

georgewrmarshall Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HowardBraham Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Mar 4, 2025

Uh oh!

georgewrmarshall left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Mar 5, 2025

Uh oh!

davidmurdoch left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

HowardBraham commented Mar 1, 2025 •

edited by github-actions bot

Loading

georgewrmarshall Mar 4, 2025 •

edited

Loading

georgewrmarshall left a comment •

edited

Loading

davidmurdoch left a comment •

edited

Loading