Update ESLint shared config to v3 #9274

whymarrh · 2020-08-19T14:17:40Z

This PR updates the ESLint config to the latest version, v3.

There are two commits with fixes, one that's automated and one that was manual. Only the first and last commit require review.

I disabled the following:

default-param-last was too annoying to fix
require-atomic-updates was also too annoying to fix
import/no-unassigned-import all the instances of this in the codebase are legitimate—I don't think we should enable it if every time it flags something we need to disable it

I'm open to enabling those in separate PRs in the future, should someone feel inclined.

Gudahtt · 2020-08-19T15:05:22Z

app/scripts/controllers/threebox.js

@@ -1,4 +1,9 @@
 import ObservableStore from 'obs-store'
+
+/* eslint-disable import/first,import/order */


Are these rules disabled here because they conflicted with each other?

They're disabled here because they both apply to the following code

import/first wants the require and imports to move

import/order wants the require call alone to move

They're both disabled here and re-enabled as soon as ESLint will allow.

The e2e tests break if I move the require call so I don't want to move it

Gudahtt · 2020-08-19T15:19:15Z

...e-container/permission-page-container-content/permission-page-container-content.component.js

-      ],
-    )
-
+    return t('connectTo', [


What motivated this change 🤔

Whoops, habit—I'd meant to only remove the extra newline but got carried away

whymarrh · 2020-08-19T15:21:41Z

ui/app/helpers/utils/fetch-with-cache.js

+  const _fetch = timeout
+    ? fetchWithTimeout({ timeout })
+    : window.fetch


These changes are extraneous, not suggested by ESLint

Gudahtt · 2020-08-19T15:38:00Z

app/scripts/migrations/002.js

  version,

-  migrate: function (originalVersionedData) {
+  migrate (originalVersionedData) {


What syntax is this O_O

Method definitions:

Starting with ECMAScript 2015, a shorter syntax for method definitions on objects initializers is introduced. It is a shorthand for a function assigned to the method's name.

Gudahtt · 2020-08-19T15:45:10Z

development/build/index.js

        manifestTasks.dev,
        reload,
      ),
-    ),


This change is unexpected. I prefer the older format, and I'm not sure what could have caused this 🤔

The first arg to the function is mis-aligned, causing the auto-fix to do this. I'll fix this with db7f5f2.

The same problem is present in many other places, but I'm not gonna block on it. Hopefully prettier will fix it.

Gudahtt · 2020-08-19T15:47:30Z

test/lib/createTxMeta.js

    status: 'unapproved',
-    txParams: {},
-  }, partialMeta)
+    txParams: {}, ...partialMeta,


It's weird to see multi-line object literals with things doubled up on the same line like this 🤔 I would have expected this to be disallowed.

I'm not sure why this is allowed. I've fixed it with 4ae9694.

The same problem is present in many other places, but I'm not gonna block on it. Hopefully prettier will fix it.

ui/app/ducks/gas/gas-duck.test.js

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

Gudahtt

LGTM!

* origin/develop: (137 commits) Use @metamask/eslint-config@3.1.0 (#9275) Standardize scss import practices (#9183) Update ESLint shared config to v3 (#9274) Add lock icon to default networks (#9269) Adds toPrecisionWithoutTrailingZeros utility (#9270) Hide gas estimate on non-main network (#9189) Move the mascot component to its own directory (#9272) Use @metamask/controllers@2.0.5 (#9266) Fix padding, alignment of actionable-message; add left aligned story Code cleanup and simplification for actionable-message component Adds actionable message component and stories Fix lint issues (#9265) Fix prefer-destructuring issues (#9263) colocate confirm-decrypt-message page styles (#9252) Tidy up Migrator tests (#9264) Adds pulse loader component (#9259) Fix import/order issues (#9239) Fix radix issues (#9247) New info tooltip component (#9180) Improve scss naming ...

@davidmurdoch

#30661) ## **Description** @davidmurdoch requested this feature here: #30440 (review) Also adds to the VSCode GitLens settings. If a Cursor user could help with the Cursor settings, that would be much appreciated. We should discuss: - The inclusion of #17092, as I'm undecided about it - Whether it's appropriate to automatically execute `git config blame.ignoreRevsFile .git-blame-ignore-revs` in `postinstall`. It writes to the local `.git/config` file in your `metamask-extension` folder, so it's only changing that one folder. Command to get commits with over 200 file changes ``` git log --pretty=format:"%H %s" --shortstat | awk '{if ($1 ~ /^[0-9]+$/) {num = $1 + 0; if (num > 200 && current_hash !~ /Revert/) print num " " current_hash} else current_hash = $0}' | sort -nr ``` [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30661?quickstart=1) ## **Related issues** David Murdoch request: #30440 (review) ## **Ignored PRs** - #6304 - #7730 - #8023 - #8056 - #8595 - #9239 - #9274 - #10358 - #10655 - #10911 - #17092 - #22639 - #22531 - #30440  --------- Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>

whymarrh added 3 commits August 19, 2020 11:35

Update to shared ESLint config v3

36c28ef

yarn lint --fix

4f9dc7f

Small manual fixes

9e54a7c

whymarrh force-pushed the eslint-shared-config-v3 branch from 40f3a5f to 9e54a7c Compare August 19, 2020 14:45

whymarrh mentioned this pull request Aug 19, 2020

Update MetaMask ESLint config to v2 #8982

Closed

whymarrh marked this pull request as ready for review August 19, 2020 14:53

whymarrh requested review from a team and kumavis as code owners August 19, 2020 14:53

whymarrh requested a review from Gudahtt August 19, 2020 14:53

Gudahtt reviewed Aug 19, 2020

View reviewed changes

whymarrh commented Aug 19, 2020

View reviewed changes

Gudahtt reviewed Aug 19, 2020

View reviewed changes

Update function-paren-newline fixes

db7f5f2

Gudahtt reviewed Aug 19, 2020

View reviewed changes

Fix alignment of createTxMeta

4ae9694

Gudahtt reviewed Aug 19, 2020

View reviewed changes

ui/app/ducks/gas/gas-duck.test.js Outdated Show resolved Hide resolved

Remove extra newline

ae1f443

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

Gudahtt approved these changes Aug 19, 2020

View reviewed changes

whymarrh merged commit b6ccd22 into MetaMask:develop Aug 19, 2020

whymarrh deleted the eslint-shared-config-v3 branch August 19, 2020 16:27

HowardBraham mentioned this pull request Mar 1, 2025

style: make Git blame ignore specified large refactor and lint commits #30661

Merged

		@@ -1,4 +1,9 @@
		import ObservableStore from 'obs-store'

		/* eslint-disable import/first,import/order */

Update ESLint shared config to v3 #9274

Update ESLint shared config to v3 #9274

Uh oh!

Conversation

whymarrh commented Aug 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Gudahtt left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

whymarrh commented Aug 19, 2020 •

edited

Loading