Use foreign keys for model/proto version references in Experiment table#250
Merged
sroderick-g5sro merged 19 commits intomasterfrom Feb 11, 2020
Merged
Use foreign keys for model/proto version references in Experiment table#250sroderick-g5sro merged 19 commits intomasterfrom
sroderick-g5sro merged 19 commits intomasterfrom
Conversation
sroderick-g5sro
commented
Feb 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
========================================
Coverage ? 94.6%
========================================
Files ? 65
Lines ? 2656
Branches ? 278
========================================
Hits ? 2513
Misses ? 104
Partials ? 39
Continue to review full report at Codecov.
|
jonc125
changed the title
jonc125
requested changes
Feb 11, 2020
Contributor
jonc125
left a comment
jonc125
left a comment
There was a problem hiding this comment.
This is looking good! I think all my suggestions are minor ones - either slight tidies to tests, or slight extra refactoring that's now possible.
Contributor
Author
|
thank you for your detailed comments - I hope I have got everything. |
jonc125
approved these changes
Feb 11, 2020
Contributor
jonc125
left a comment
jonc125
left a comment
There was a problem hiding this comment.
Looks good! Just some flake8 issues to sort. You might want to set up the git pre-commit hook to catch those for you?
flake8 --install-hook=git
git config --bool flake8.strict true
MauriceHendrix
pushed a commit
that referenced
this pull request
Jul 22, 2021
…-link Use foreign keys for model/proto version references in Experiment table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preliminary refactor suggested in #241.