You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Viewing results should hopefully just reuse code from #131 etc. But we'll need to do (at least some of) #135 before this can be fully implemented and tested.
The plan is being sketched out further in #203 and #241. Possible steps:
This will mean that the RunningExperiment table won't need changing for fitting experiments, and indeed receipt of finished experiments in experiments/processing.py:process_callback (and cancelling running experiments) won't need any additions.
To get submission of fitting experiments to work we'll need a 'fitting' version of experiments/processing.py:submit_experiment that creates the FittingResult etc instances. We may be able to refactor so they share some code though.
We don't want to try automatically migrating existing hacky fitting specs (stored as Protocol instances) to FittingSpec instances etc. Instead manually re-create ones we care about (just one really! i.e. Kylie since wave cell 5).
Probably in a
fittingapp, cf #133?See https://github.com/ModellingWebLab/project_issues/wiki/Workshop-notes-2018 for ideas.
Viewing results should hopefully just reuse code from #131 etc. But we'll need to do (at least some of) #135 before this can be fully implemented and tested.
The plan is being sketched out further in #203 and #241. Possible steps:
Runnablerefactor outlined in First outline of fitting result models #241, with DB migrations, ensuring tests still pass etc. This can be a single PR.RunningExperimenttable won't need changing for fitting experiments, and indeed receipt of finished experiments inexperiments/processing.py:process_callback(and cancelling running experiments) won't need any additions.FittingResultmodel inspired by the outline in First outline of fitting result models #241. No views initially, just tests of the model directly? (Likeexperiments/tests/test_models.py)FittingResultandFittingResultVersionmodels.FittingResultneeds to link to repocache tables for entity versions, not use SHA strings.experiments/views.py, trying to reuse code where possible as was done for the specs & datasets:FittingResultVersionListViewFittingResultVersionViewFittingResultVersionJsonViewFittingResultDeleteViewFittingResultVersionDeleteViewFittingResultFileDownloadViewFittingResultVersionArchiveViewsubmit_experimentto createFittingResultetc. instances, refactoring to share code where possible.FittingResultComparison[Json]ViewGeneral notes:
experiments/processing.py:submit_experimentthat creates theFittingResultetc instances. We may be able to refactor so they share some code though.Protocolinstances) toFittingSpecinstances etc. Instead manually re-create ones we care about (just one really! i.e. Kylie since wave cell 5).