Closed
Conversation
Contributor
|
Yeah, no need to migrate the old hacky specs, there is pretty much only one that people copied and pasted and nobody's using it in anger! |
Contributor
Contributor
Author
|
You might find it easier to create a new branch off develop rather than rebasing? But I'm happy either way! |
Some models in repocache are now referenced using names to avoid circular imports
a28a57b to
d3f66aa
Compare
d3f66aa to
795784d
Compare
bbf1eab to
900157e
Compare
59fc29c to
c83d30b
Compare
5f063a3 to
27df52b
Compare
Fitting result URLs get their own subnamespace within the fitting app
f894208 to
f926146
Compare
f926146 to
5df21fe
Compare
Contributor
|
Closing so I can create new PR on this branch under my username... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done as a thinking aloud kind of exercise. I think this is along the right lines, but I'm not sure we want to start from here!
The reason is that we may wish to refactor the
Experimentmodel first so it refers toCachedProtocolVersionandCachedModelVersioninstead of storing string SHA values inprotocol_versionandmodel_version. When it was originally written, the repocache didn't exist. And then when we first added it we assumed it could be fully ephemeral and just regenerated as needed. But increasingly it is storing data that is expensive to recompute, and the populate method ensures that cache entries are only removed if the corresponding commit is removed, so it is as permanent as our knowledge of the underlying repo. If the commit is removed, we probably do want to remove linked experiment results.What do you think @sroderick-g5sro ?
Then related thoughts building on this...
FittingResulthere.Runnableabstraction. In particular, it means that theRunningExperimenttable can remain as-is, and indeed receipt of finished experiments inexperiments/processing.py:process_callback(and cancelling running experiments) doesn't need any additions for fitting experiments!experiments/processing.py:submit_experimentthat creates theFittingResultetc instances. We may be able to refactor so they share some code though.Protocolinstances) toFittingSpecinstances etc. Instead manually migrate ones we care about. It seems likely to be too difficult to split the data & spec & protocol file out into sensible places. Would you agree @mirams ?