Introduction of runnable base class to assist with introduction of fitting specs#253
Merged
Introduction of runnable base class to assist with introduction of fitting specs#253
Conversation
Contributor
Author
|
Hi @jonc125. I am submitting this pull request for your review but I am aware of a number of issues:
In general it would be good to get your feedback on the approach I have taken in this change please |
sroderick-g5sro
commented
Feb 27, 2020
sroderick-g5sro
commented
Feb 27, 2020
sroderick-g5sro
commented
Feb 27, 2020
jonc125
requested changes
Feb 27, 2020
Contributor
jonc125
left a comment
There was a problem hiding this comment.
This was a complicated one to get right! I've worked through the migrations, and think I can see a pathway to getting it working. See what you think of my suggestions.
jonc125
reviewed
Feb 28, 2020
These were created by removing much of the view logic etc (but not committing) so I could get Django to make the migrations automatically, with the exception of the one RunPython migration to move the experiment keys between models. Experiment tests pass and I can now view the matrix after migrating my local data. I'd recommend more manual testing that things still work before merging though!
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
========================================
- Coverage 94.5% 94.5% -0.1%
========================================
Files 65 65
Lines 2685 2689 +4
Branches 280 280
========================================
+ Hits 2540 2543 +3
- Misses 105 106 +1
Partials 40 40
Continue to review full report at Codecov.
|
MauriceHendrix
pushed a commit
that referenced
this pull request
Jul 22, 2021
Introduction of runnable base class to assist with introduction of fitting specs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #134