Conversation
Some models in repocache are now referenced using names to avoid circular imports
Fitting result URLs get their own subnamespace within the fitting app
jonc125
reviewed
Sep 3, 2020
Contributor
jonc125
left a comment
jonc125
left a comment
There was a problem hiding this comment.
I've not gone through all of this yet, but the models and views certainly look to be along the right lines!
| model = FittingResult | ||
|
|
||
| def get_success_url(self, *args, **kwargs): | ||
| return reverse('experiments:list') + '?show_fits=true' |
Contributor
There was a problem hiding this comment.
This will need to change once we have a proper matrix view for fitting results!
Contributor
There was a problem hiding this comment.
Or it could redirect to one of the simpler views from #276 in the interim?
jonc125
reviewed
Sep 4, 2020
jonc125
reviewed
Sep 4, 2020
jonc125
reviewed
Sep 4, 2020
Contributor
jonc125
left a comment
jonc125
left a comment
There was a problem hiding this comment.
I've now gone through the rest of the PR; all looking good so far.
helenst
force-pushed
the
203-fitting-result
branch
from
7921759 to
b8ab9cb
Compare
Currently, these are equivalent to the experiment comparison views. They will need adapting to fitting experiments.
helenst
force-pushed
the
203-fitting-result
branch
from
b8ab9cb to
7549c5d
Compare
Closed
13 tasks
Include dataset and fitting spec names / versions
Include fitting spec and dataset names and versions, different possibilities for different entity / version comparisons
helenst
force-pushed
the
203-fitting-result
branch
from
1b89fbd to
f99a2ca
Compare
helenst
force-pushed
the
203-fitting-result
branch
from
f99a2ca to
28d5ad4
Compare
helenst
force-pushed
the
203-fitting-result
branch
from
28d5ad4 to
c73e9bc
Compare
jonc125
requested changes
Sep 24, 2020
Contributor
jonc125
left a comment
jonc125
left a comment
There was a problem hiding this comment.
Fitting experiments are still running so I can't compare results yet, but I've found 2 minor issues from what I can see so far.
Contributor
Contributor
Author
|
Great! I think at this point it'd be easier to roll it all into one :) |
jonc125
approved these changes
Sep 25, 2020
MauriceHendrix
pushed a commit
that referenced
this pull request
Jul 22, 2021
Fitting result models and views
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapted from #241 to address #134.
I've updated the comparison js to account for the new types on the
FittingResultmodel. It should still work for Experiments.