Set default Torch version if YY.MM format is not met by thomasdhc · Pull Request #9776 · NVIDIA-NeMo/NeMo

thomasdhc · 2024-07-17T21:12:46Z

What does this PR do ?

Set default nvidia torch version

Collection: [nlp]

Changelog

Update nvidia torch version if YY.MM formatting is not met

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you add or update any necessary documentation?
Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

New Feature
Bugfix
Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Related to # (issue)

… formatting is not met Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>

nemo/collections/nlp/models/language_modeling/megatron_base_model.py

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>

ericharper · 2024-07-23T17:23:28Z

nemo/collections/nlp/models/language_modeling/megatron_base_model.py

+        def is_official_release_version(nvidia_torch_version):
+            return re.fullmatch("[0-9][0-9]\.[0-9][0-9].*", nvidia_torch_version)  # "YY.MM.*"


This is currently in the nemo 1.0 path, we'll need something similar for 2.0

@thomasdhc Can we unblock this for 1.0 and file a JIRA for the 2.0 code path ?

ericharper · 2024-07-23T17:25:32Z

@minitu could you review this PR?

minitu · 2024-07-23T17:54:40Z

LGTM

gautham-kollu

Approving.

Please file a corresponding bug for 2.0.

* Torch major and minor versions set to current year and month if YY.MM formatting is not met Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Update nvidia torch version check Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Remove redundant import Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Formatting fix Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> --------- Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> Co-authored-by: Dong Hyuk Chang <donghyukc@nvidia.com>

* Torch major and minor versions set to current year and month if YY.MM formatting is not met Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Update nvidia torch version check Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Remove redundant import Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Formatting fix Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> --------- Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> Co-authored-by: Dong Hyuk Chang <donghyukc@nvidia.com> Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>

* Torch major and minor versions set to current year and month if YY.MM formatting is not met Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Update nvidia torch version check Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Remove redundant import Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Formatting fix Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> --------- Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> Co-authored-by: Dong Hyuk Chang <donghyukc@nvidia.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* Torch major and minor versions set to current year and month if YY.MM formatting is not met Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Update nvidia torch version check Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Remove redundant import Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Formatting fix Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> --------- Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> Co-authored-by: Dong Hyuk Chang <donghyukc@nvidia.com> Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>

* Torch major and minor versions set to current year and month if YY.MM formatting is not met Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Update nvidia torch version check Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Remove redundant import Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Formatting fix Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> --------- Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> Co-authored-by: Dong Hyuk Chang <donghyukc@nvidia.com> Signed-off-by: Vivian Chen <xuanzic@example.com>

* Update arch check for SD (#9783) * Update arch check for SD Signed-off-by: Jaemin Choi <jaeminc@nvidia.com> * Apply isort and black reformatting Signed-off-by: minitu <minitu@users.noreply.github.com> --------- Signed-off-by: Jaemin Choi <jaeminc@nvidia.com> Signed-off-by: minitu <minitu@users.noreply.github.com> Co-authored-by: Jaemin Choi <jaeminc@nvidia.com> Co-authored-by: minitu <minitu@users.noreply.github.com> Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Set default Torch version if YY.MM format is not met (#9776) * Torch major and minor versions set to current year and month if YY.MM formatting is not met Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Update nvidia torch version check Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Remove redundant import Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Formatting fix Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> --------- Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> Co-authored-by: Dong Hyuk Chang <donghyukc@nvidia.com> Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> --------- Signed-off-by: Jaemin Choi <jaeminc@nvidia.com> Signed-off-by: minitu <minitu@users.noreply.github.com> Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> Co-authored-by: Jaemin Choi <minitu77@gmail.com> Co-authored-by: Jaemin Choi <jaeminc@nvidia.com> Co-authored-by: minitu <minitu@users.noreply.github.com> Co-authored-by: Dong Hyuk Chang <donghyukc@nvidia.com>

* Torch major and minor versions set to current year and month if YY.MM formatting is not met Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Update nvidia torch version check Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Remove redundant import Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Formatting fix Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> --------- Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> Co-authored-by: Dong Hyuk Chang <donghyukc@nvidia.com>

* Torch major and minor versions set to current year and month if YY.MM formatting is not met Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Update nvidia torch version check Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Remove redundant import Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Formatting fix Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> --------- Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> Co-authored-by: Dong Hyuk Chang <donghyukc@nvidia.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Torch major and minor versions set to current year and month if YY.MM formatting is not met Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Update nvidia torch version check Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Remove redundant import Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Formatting fix Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> --------- Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> Co-authored-by: Dong Hyuk Chang <donghyukc@nvidia.com>

github-actions bot added the NLP label Jul 17, 2024

Torch major and minor versions set to current year and month if YY.MM…

1b9e9a2

… formatting is not met Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>

thomasdhc force-pushed the donghyukc/optimizations_nv_version branch from 9841bbb to 1b9e9a2 Compare July 17, 2024 21:13

Update nvidia torch version check

81fa490

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>

github-advanced-security bot found potential problems Jul 18, 2024

View reviewed changes

nemo/collections/nlp/models/language_modeling/megatron_base_model.py Fixed Show fixed Hide fixed

thomasdhc added 2 commits July 18, 2024 09:22

Remove redundant import

92b6305

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>

Formatting fix

cd9e276

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>

thomasdhc added the Run CICD label Jul 18, 2024

thomasdhc requested a review from ericharper July 18, 2024 17:51

ericharper reviewed Jul 23, 2024

View reviewed changes

Merge branch 'main' into donghyukc/optimizations_nv_version

ce2754d

thomasdhc added Run CICD and removed Run CICD labels Jul 23, 2024

athitten mentioned this pull request Jul 23, 2024

Disable nvFuser setup with PyTorch 23.11 and later #9837

Merged

8 tasks

Merge branch 'main' into donghyukc/optimizations_nv_version

9b36af2

thomasdhc added Run CICD and removed Run CICD labels Jul 24, 2024

gautham-kollu approved these changes Jul 25, 2024

View reviewed changes

thomasdhc merged commit 7eac53c into main Jul 25, 2024

thomasdhc deleted the donghyukc/optimizations_nv_version branch July 25, 2024 18:15

thomasdhc mentioned this pull request Jul 25, 2024

Support Nvidia Torch and Arch versions #9897

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set default Torch version if YY.MM format is not met#9776

Set default Torch version if YY.MM format is not met#9776
thomasdhc merged 6 commits intomainfrom
donghyukc/optimizations_nv_version

thomasdhc commented Jul 17, 2024

Uh oh!

Uh oh!

ericharper Jul 23, 2024

Uh oh!

gautham-kollu Jul 23, 2024

Uh oh!

ericharper commented Jul 23, 2024

Uh oh!

minitu commented Jul 23, 2024

Uh oh!

gautham-kollu left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

		def is_official_release_version(nvidia_torch_version):
		return re.fullmatch("[0-9][0-9]\.[0-9][0-9].", nvidia_torch_version) # "YY.MM."

Conversation

thomasdhc commented Jul 17, 2024

What does this PR do ?

Changelog

Usage

GitHub Actions CI

Before your PR is "Ready for review"

Who can review?

Additional Information

Uh oh!

Uh oh!

ericharper Jul 23, 2024

Choose a reason for hiding this comment

Uh oh!

gautham-kollu Jul 23, 2024

Choose a reason for hiding this comment

Uh oh!

ericharper commented Jul 23, 2024

Uh oh!

minitu commented Jul 23, 2024

Uh oh!

gautham-kollu left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments