Skip to content

Update arch check for SD#9783

Merged
thomasdhc merged 3 commits intoNVIDIA-NeMo:mainfrom
minitu:sd_arch
Jul 24, 2024
Merged

Update arch check for SD#9783
thomasdhc merged 3 commits intoNVIDIA-NeMo:mainfrom
minitu:sd_arch

Conversation

@minitu
Copy link
Collaborator

@minitu minitu commented Jul 18, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>
minitu and others added 2 commits July 22, 2024 17:01
Signed-off-by: minitu <minitu@users.noreply.github.com>
@ericharper ericharper requested review from thomasdhc and yaoyu-33 July 23, 2024 17:26
Copy link
Collaborator

@thomasdhc thomasdhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasdhc
Copy link
Collaborator

@minitu There's one CI test failing. Does not look relevant to the change introduced here?

@minitu
Copy link
Collaborator Author

minitu commented Jul 24, 2024

The CI failure doesn't seem relevant to this PR:

Error executing job with overrides: ['model.restore_from_path=/home/TestData/nlp/megatron_llama/llama_ci.nemo', 'quantization.calib_dataset=/home/TestData/nlp/test_quantization/test.json', 'quantization.algorithm=int8_sq', 'quantization.num_calib_size=8', 'inference.batch_size=2', 'export.save_path=/home/TestData/nlp/megatron_llama/ci_int8_sq.qnemo']
Traceback (most recent call last):
  File "/workspace/Megatron-LM/megatron/core/dist_checkpointing/strategies/common.py", line 85, in load_sharded_object
    loaded_obj = torch.load(load_path)
  File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 997, in load
    with _open_file_like(f, 'rb') as opened_file:
  File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 444, in _open_file_like
    return _open_file(name_or_buffer, mode)
  File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 425, in __init__
    super().__init__(open(name, mode))
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmp4ev5r7lk/model_weights/model.decoder.layers.self_attention.linear_proj._extra_state/shard_0_2.pt'

@thomasdhc thomasdhc merged commit cd0d2c2 into NVIDIA-NeMo:main Jul 24, 2024
thomasdhc pushed a commit that referenced this pull request Jul 25, 2024
* Update arch check for SD

Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: minitu <minitu@users.noreply.github.com>

---------

Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>
Signed-off-by: minitu <minitu@users.noreply.github.com>
Co-authored-by: Jaemin Choi <jaeminc@nvidia.com>
Co-authored-by: minitu <minitu@users.noreply.github.com>
thomasdhc pushed a commit that referenced this pull request Jul 25, 2024
* Update arch check for SD

Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: minitu <minitu@users.noreply.github.com>

---------

Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>
Signed-off-by: minitu <minitu@users.noreply.github.com>
Co-authored-by: Jaemin Choi <jaeminc@nvidia.com>
Co-authored-by: minitu <minitu@users.noreply.github.com>
Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
akoumpa pushed a commit that referenced this pull request Jul 25, 2024
* Update arch check for SD

Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: minitu <minitu@users.noreply.github.com>

---------

Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>
Signed-off-by: minitu <minitu@users.noreply.github.com>
Co-authored-by: Jaemin Choi <jaeminc@nvidia.com>
Co-authored-by: minitu <minitu@users.noreply.github.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Jul 30, 2024
* Update arch check for SD

Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: minitu <minitu@users.noreply.github.com>

---------

Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>
Signed-off-by: minitu <minitu@users.noreply.github.com>
Co-authored-by: Jaemin Choi <jaeminc@nvidia.com>
Co-authored-by: minitu <minitu@users.noreply.github.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
xuanzic pushed a commit to xuanzic/NeMo that referenced this pull request Aug 1, 2024
* Update arch check for SD

Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: minitu <minitu@users.noreply.github.com>

---------

Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>
Signed-off-by: minitu <minitu@users.noreply.github.com>
Co-authored-by: Jaemin Choi <jaeminc@nvidia.com>
Co-authored-by: minitu <minitu@users.noreply.github.com>
Signed-off-by: Vivian Chen <xuanzic@example.com>
ericharper pushed a commit that referenced this pull request Aug 1, 2024
* Update arch check for SD (#9783)

* Update arch check for SD

Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: minitu <minitu@users.noreply.github.com>

---------

Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>
Signed-off-by: minitu <minitu@users.noreply.github.com>
Co-authored-by: Jaemin Choi <jaeminc@nvidia.com>
Co-authored-by: minitu <minitu@users.noreply.github.com>
Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>

* Set default Torch version if YY.MM format is not met (#9776)

* Torch major and minor versions set to current year and month if YY.MM formatting is not met

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>

* Update nvidia torch version check

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>

* Remove redundant import

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>

* Formatting fix

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>

---------

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
Co-authored-by: Dong Hyuk Chang <donghyukc@nvidia.com>
Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>

---------

Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>
Signed-off-by: minitu <minitu@users.noreply.github.com>
Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
Co-authored-by: Jaemin Choi <minitu77@gmail.com>
Co-authored-by: Jaemin Choi <jaeminc@nvidia.com>
Co-authored-by: minitu <minitu@users.noreply.github.com>
Co-authored-by: Dong Hyuk Chang <donghyukc@nvidia.com>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
* Update arch check for SD

Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: minitu <minitu@users.noreply.github.com>

---------

Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>
Signed-off-by: minitu <minitu@users.noreply.github.com>
Co-authored-by: Jaemin Choi <jaeminc@nvidia.com>
Co-authored-by: minitu <minitu@users.noreply.github.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* Update arch check for SD

Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: minitu <minitu@users.noreply.github.com>

---------

Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>
Signed-off-by: minitu <minitu@users.noreply.github.com>
Co-authored-by: Jaemin Choi <jaeminc@nvidia.com>
Co-authored-by: minitu <minitu@users.noreply.github.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
* Update arch check for SD

Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: minitu <minitu@users.noreply.github.com>

---------

Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>
Signed-off-by: minitu <minitu@users.noreply.github.com>
Co-authored-by: Jaemin Choi <jaeminc@nvidia.com>
Co-authored-by: minitu <minitu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments