Support Nvidia Torch and Arch versions#9897
Merged
ericharper merged 2 commits intor2.0.0rc1from Aug 1, 2024
Merged
Conversation
* Update arch check for SD Signed-off-by: Jaemin Choi <jaeminc@nvidia.com> * Apply isort and black reformatting Signed-off-by: minitu <minitu@users.noreply.github.com> --------- Signed-off-by: Jaemin Choi <jaeminc@nvidia.com> Signed-off-by: minitu <minitu@users.noreply.github.com> Co-authored-by: Jaemin Choi <jaeminc@nvidia.com> Co-authored-by: minitu <minitu@users.noreply.github.com> Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
* Torch major and minor versions set to current year and month if YY.MM formatting is not met Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Update nvidia torch version check Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Remove redundant import Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> * Formatting fix Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> --------- Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> Co-authored-by: Dong Hyuk Chang <donghyukc@nvidia.com> Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
thomasdhc
force-pushed
the
donghyukc/support_nv_arch_version
branch
from
e9d1a93 to
5531786
Compare
Collaborator
Author
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Cherry picking two PRs into r2.0.0rc1
#9776
#9783
Collection: [nlp],[multimodal]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information