APX-825 #401
Closed
APX-825 #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch method has to be called in ``_register_hook``. When a method is patched, any call to the method will not directly execute the method's body, but will instead enqueue a job. When a ``context_key`` is set when calling ``_patch_job_auto_delay``, the patched method is automatically delayed only when this key is ``True`` in the caller's context. It is advised to patch the method with a ``context_key``, because making the automatic delay *in any case* can produce nasty and unexpected side effects (e.g. another module calls the method and expects it to be computed before doing something else, expecting a result, ...). A typical use case is when a method in a module we don't control is called synchronously in the middle of another method, and we'd like all the calls to this method become asynchronous. It relies on OCA#274 that deprecates the `@job` decorator.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: queue-13.0/queue-13.0-queue_job Translate-URL: https://translation.odoo-community.org/projects/queue-13-0/queue-13-0-queue_job/
Following changes of OCA#281 The initial sudo() is lost when we call "with_env()" with a False su flag. Ensure the read job.record keeps a su flag.
Currently translated at 86.5% (116 of 134 strings) Translation: queue-13.0/queue-13.0-queue_job Translate-URL: https://translation.odoo-community.org/projects/queue-13-0/queue-13-0-queue_job/zh_CN/
Currently translated at 89.5% (120 of 134 strings) Translation: queue-13.0/queue-13.0-queue_job Translate-URL: https://translation.odoo-community.org/projects/queue-13-0/queue-13-0-queue_job/zh_CN/
These fields should not be changed by users.
Everytime a job is created, a mail.message "Queue Job created" is created. This is useless, as we already have the creation date and user, and nobody will ever want to receive a notification for a created job anyway. Removing the on creation auto-subscription of the user that created the job makes sense as well since we automatically subscribe the queue job managers for failures. Add the owner of the jobs to the followers on failures only as well. It allows to remove a lot of insertions of records (and of deletions when autovacuuming jobs).
Several fields on queue.job are initialized using computed fields, then never changed again. On creation of a queue.job record, we'll have an initial INSERT + at least one following UPDATE for the computed fields. Replace all the stored computed fields by a raw initialization of the values in `Job.store()` when the job is created, so we have only a single INSERT. Highlights: * as channel is no longer a compute/inverse field, override_channel is useless, I dropped it (actually the same value was stored in both channel and override_channel as the channel field was stored) * one functional diff is that now, when changing a channel on a job.function, the channel is no longer synchronized on existing jobs, it will be applied only on new jobs: actually this is an improvement, because it was impossible to change the channel of a job function in a large queue_job table as it meant writing on all the done/started jobs * searching the queue.job.function is now cached, as each job using the same will run a query on queue_job_function
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: queue-13.0/queue-13.0-queue_job Translate-URL: https://translation.odoo-community.org/projects/queue-13-0/queue-13-0-queue_job/
When RetryableJobError was raised, any change done by the job was not rollbacked. Using `raise` would throw the exception up to the core and rollback, but we would have a stack trace in the logs for each try. Calling rollback manually (rollback also clears the env) hide the tracebacks, however, when the last try fails, the full traceback is still shown in the logs. Fixes OCA#261
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: queue-13.0/queue-13.0-queue_job Translate-URL: https://translation.odoo-community.org/projects/queue-13-0/queue-13-0-queue_job/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: queue-13.0/queue-13.0-queue_job Translate-URL: https://translation.odoo-community.org/projects/queue-13-0/queue-13-0-queue_job/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: queue-13.0/queue-13.0-queue_job Translate-URL: https://translation.odoo-community.org/projects/queue-13-0/queue-13-0-queue_job/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: queue-13.0/queue-13.0-test_queue_job Translate-URL: https://translation.odoo-community.org/projects/queue-13-0/queue-13-0-test_queue_job/
The float_time widget shows hours seconds, we only want seconds. The widget had been removed on the form view, but not on the tree view.
…b will not execute untill parent will be done.
Member
|
Hi @KalpeshGajera, I see you are working on a dependency system for jobs. You should have a look on #154 which is waiting for reviews. The latter PR targets 12.0, but as it is not approved yet, I never worked on adapting it to newer versions. |
Member
|
@KalpeshGajera here's the version for odoo 14.0 #403 |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.