Merged
Conversation
Also fixes for other stuff which was half ported and needed @api decorators and testing
Contributor
Author
|
Leaving this PR open, but deploying this branch to staging, after rebasing prod |
james-opusvl
approved these changes
Mar 19, 2018
[IMP] More fields on the mobile view should be required
james-opusvl
approved these changes
Mar 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Included in this is a port of the old api allocation file.
Batch allocation is applied now to
Nursing Shift ChangeandNursing Re-AllocationwizardsTo complete this we needed to:
A.) Port the file to make it easier to work with
B.) Make a custom boolean JS widget which writes the value of
TRUEorFALSEto the database fornh.clinical.allocationso that it can be picked up later via the confirm allocation function, as this functonality doesn't happen as standard.C.) Instead of using a batch wizard, add a new state to the existing model. We needed this as any python function which doesn't just return the relevant allocation wizards action results in the allocation wizard closing.
D.) Unfortunately some duplication of code due to odoo model inheritance not working as expected