Pass correct draw strength for EntityShootBowEvent#12308
Merged
Owen1212055 merged 5 commits intoPaperMC:mainfrom May 2, 2025
Merged
Pass correct draw strength for EntityShootBowEvent#12308Owen1212055 merged 5 commits intoPaperMC:mainfrom
Owen1212055 merged 5 commits intoPaperMC:mainfrom
Conversation
2 tasks
Warriorrrr
added
type: bug
TonytheMacaroni
force-pushed
the
draw-strength
branch
from
b538226 to
3222985
Compare
github-project-automation
bot
moved this from Awaiting review
to Closed
in Paper PR Queue
lynxplay
requested changes
May 2, 2025
Contributor
lynxplay
left a comment
lynxplay
left a comment
There was a problem hiding this comment.
Generally LGTM, it is missing paper comments in like every file patch tho 😅
github-project-automation
bot
moved this from Awaiting review
to Changes required
in Paper PR Queue
Owen1212055
approved these changes
May 2, 2025
lynxplay
approved these changes
May 2, 2025
github-project-automation
bot
moved this from Changes required
to Awaiting final testing
in Paper PR Queue
github-project-automation
bot
moved this from Awaiting final testing
to Merged
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10640.
After testing, the broken behavior started in 1.20.5. In 1.20.4,
EntityShootBowEvent#getForceworked as expected, returning a draw strength of[0, 1]for bows, and1for crossbows.Additionally, a constant
0.8was passed for force inAbstractSkeleton#performRangedAttackandIllusioner#performRangedAttack. After checkingRangedBowAttackGoal, which calls the method with:Which prompted changing it to passing the
distanceFactorparameter as the force.