[IMPROVE] Replace livechat inquiry dialog with preview room#13986
Merged
[IMPROVE] Replace livechat inquiry dialog with preview room#13986
Conversation
renatobecker-zz
changed the title
renatobecker-zz
changed the title
renatobecker-zz
requested review from
sampaiodiego and
tassoevan
and removed request for
tassoevan
…review-room # Conflicts: # app/livechat/client/views/sideNav/livechat.js
ggazzo
previously requested changes
Apr 24, 2019
Member
ggazzo
left a comment
ggazzo
left a comment
There was a problem hiding this comment.
I really like the idea about remove html files from index import, but maybe next time, make a pr only to that :)
Hudell
approved these changes
Apr 27, 2019
rodrigok
deleted the
livechat-replace-take-inquiry-dialog-by-preview-room
branch
Merged
wreiske
added a commit
to wreiske/Rocket.Chat
that referenced
this pull request
Apr 28, 2019
…nto ldap-admin-groups * 'develop' of https://github.com/RocketChat/Rocket.Chat: (21 commits) Regression: Active room was not being marked (RocketChat#14276) Rename Cloud to Connectivity Services & split Apps in Apps and Marketplace (RocketChat#14211) LingoHub based on develop (RocketChat#14178) [IMPROVE] Replace livechat inquiry dialog with preview room (RocketChat#13986) Bump version to 0.74.3 Room loading improvements (RocketChat#13471) [FIX] Invalid condition on getting next livechat agent over REST API endpoint (RocketChat#13360) [IMPROVE] Open rooms quicker (RocketChat#13417) [FIX] "Test Desktop Notifications" not triggering a notification (RocketChat#13457) [FIX] Translated and incorrect i18n variables (RocketChat#13463) Regression: Remove console.log on email translations (RocketChat#13456) [FIX] Properly escape custom emoji names for pattern matching (RocketChat#13408) [FIX] Not translated emails (RocketChat#13452) Added missing package dependency (RocketChat#13437) Update Russian localization (RocketChat#13244) [IMPROVE] Allow configure Prometheus port per process via Env Var (RocketChat#13436) [IMPROVE] Add API option "permissionsRequired" (RocketChat#13430) [FIX] Several Problems on HipChat Importer (RocketChat#13336) Add the missing uniqueId to the push notifications (RocketChat#13423) [FIX] Notify private settings changes even on public settings changed (RocketChat#13369) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13990.
This PR replaces the current dialog used to take livechat inquiries with the new
Join Roomapproach, as shown below:In addition: When the livechat conversation is closed, only the client that requested the action is notifyed, if any other client is accessing the room, nothing happens.