Skip to content

[FIX] "Test Desktop Notifications" not triggering a notification#13457

Merged
rodrigok merged 2 commits intodevelopfrom
fix/notifications
Feb 13, 2019
Merged

[FIX] "Test Desktop Notifications" not triggering a notification#13457
rodrigok merged 2 commits intodevelopfrom
fix/notifications

Conversation

@tassoevan
Copy link
Contributor

Related to #13284

@rodrigok rodrigok merged commit 8684a26 into develop Feb 13, 2019
@rodrigok rodrigok deleted the fix/notifications branch February 13, 2019 13:19
sampaiodiego pushed a commit that referenced this pull request Feb 14, 2019
)

* Import getAvatarUrlFromUsername from meteor/rocketchat:utils instead of meteor/rocketchat:ui-utils

* Update desktop notifications preference field
@sampaiodiego sampaiodiego mentioned this pull request Feb 14, 2019
bhardwajaditya pushed a commit to bhardwajaditya/Rocket.Chat that referenced this pull request Mar 17, 2019
…ketChat#13457)

* Import getAvatarUrlFromUsername from meteor/rocketchat:utils instead of meteor/rocketchat:ui-utils

* Update desktop notifications preference field
wreiske added a commit to wreiske/Rocket.Chat that referenced this pull request Apr 28, 2019
…nto ldap-admin-groups

* 'develop' of https://github.com/RocketChat/Rocket.Chat: (21 commits)
  Regression: Active room was not being marked (RocketChat#14276)
  Rename Cloud to Connectivity Services & split Apps in Apps and Marketplace (RocketChat#14211)
  LingoHub based on develop (RocketChat#14178)
  [IMPROVE] Replace livechat inquiry dialog with preview room (RocketChat#13986)
  Bump version to 0.74.3
  Room loading improvements (RocketChat#13471)
  [FIX] Invalid condition on getting next livechat agent over REST API endpoint (RocketChat#13360)
  [IMPROVE] Open rooms quicker (RocketChat#13417)
  [FIX] "Test Desktop Notifications" not triggering a notification (RocketChat#13457)
  [FIX] Translated and incorrect i18n variables (RocketChat#13463)
  Regression: Remove console.log on email translations (RocketChat#13456)
  [FIX] Properly escape custom emoji names for pattern matching (RocketChat#13408)
  [FIX] Not translated emails (RocketChat#13452)
  Added missing package dependency (RocketChat#13437)
  Update Russian localization (RocketChat#13244)
  [IMPROVE] Allow configure Prometheus port per process via Env Var (RocketChat#13436)
  [IMPROVE] Add API option "permissionsRequired" (RocketChat#13430)
  [FIX] Several Problems on HipChat Importer (RocketChat#13336)
  Add the missing uniqueId to the push notifications (RocketChat#13423)
  [FIX] Notify private settings changes even on public settings changed (RocketChat#13369)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui Touches the code on client side feat: notification type: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments