Skip to content

[FIX] Not translated emails#13452

Merged
rodrigok merged 2 commits intodevelopfrom
fix-not-translated-emails
Feb 12, 2019
Merged

[FIX] Not translated emails#13452
rodrigok merged 2 commits intodevelopfrom
fix-not-translated-emails

Conversation

@sampaiodiego
Copy link
Member

Some emails were not translated due to two main issues:

  • Wrong language setting - 351c44a
  • Mailer was not looking for server's default language - 3d15fb2

@sampaiodiego sampaiodiego added this to the 0.74.3 milestone Feb 12, 2019
@rodrigok rodrigok merged commit d2cd359 into develop Feb 12, 2019
@rodrigok rodrigok deleted the fix-not-translated-emails branch February 12, 2019 17:21
sampaiodiego added a commit that referenced this pull request Feb 14, 2019
* Fix misspelled language setting name

* Fix emails translations not using server's language
@sampaiodiego sampaiodiego mentioned this pull request Feb 14, 2019
bhardwajaditya pushed a commit to bhardwajaditya/Rocket.Chat that referenced this pull request Mar 17, 2019
* Fix misspelled language setting name

* Fix emails translations not using server's language
wreiske added a commit to wreiske/Rocket.Chat that referenced this pull request Apr 28, 2019
…nto ldap-admin-groups

* 'develop' of https://github.com/RocketChat/Rocket.Chat: (21 commits)
  Regression: Active room was not being marked (RocketChat#14276)
  Rename Cloud to Connectivity Services & split Apps in Apps and Marketplace (RocketChat#14211)
  LingoHub based on develop (RocketChat#14178)
  [IMPROVE] Replace livechat inquiry dialog with preview room (RocketChat#13986)
  Bump version to 0.74.3
  Room loading improvements (RocketChat#13471)
  [FIX] Invalid condition on getting next livechat agent over REST API endpoint (RocketChat#13360)
  [IMPROVE] Open rooms quicker (RocketChat#13417)
  [FIX] "Test Desktop Notifications" not triggering a notification (RocketChat#13457)
  [FIX] Translated and incorrect i18n variables (RocketChat#13463)
  Regression: Remove console.log on email translations (RocketChat#13456)
  [FIX] Properly escape custom emoji names for pattern matching (RocketChat#13408)
  [FIX] Not translated emails (RocketChat#13452)
  Added missing package dependency (RocketChat#13437)
  Update Russian localization (RocketChat#13244)
  [IMPROVE] Allow configure Prometheus port per process via Env Var (RocketChat#13436)
  [IMPROVE] Add API option "permissionsRequired" (RocketChat#13430)
  [FIX] Several Problems on HipChat Importer (RocketChat#13336)
  Add the missing uniqueId to the push notifications (RocketChat#13423)
  [FIX] Notify private settings changes even on public settings changed (RocketChat#13369)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments