[FIX] Wrong message count statistics in Admin info page#16680
Merged
sampaiodiego merged 7 commits intoRocketChat:developfrom Mar 26, 2020
Merged
[FIX] Wrong message count statistics in Admin info page#16680sampaiodiego merged 7 commits intoRocketChat:developfrom
sampaiodiego merged 7 commits intoRocketChat:developfrom
Conversation
…6680-subham103-fixMessageCountStatistics * 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits) [FIX] ie11 support (RocketChat#16682) Regression: Show upload errors (RocketChat#16681) [FIX] Delete messages while searching bug (RocketChat#16568) Use insertSync [FIX] Image uploads (thumbnails) out of threads are not visible in regular message view (RocketChat#16416) [FIX] Added an option to pin/unpin a thread message by admin (RocketChat#16457) [CHORE] Look for Storybook stories on `app/` too (RocketChat#16595) [IMPROVE] Removed the 'reply in thread' from thread replies (RocketChat#16630) [FIX] Changed Opt_In message (RocketChat#16631) [FIX] LDAP sync admin action was not syncing exisent users (RocketChat#16671) [IMPROVE] Check agent status when starting a new conversation with an agent assigned (RocketChat#16618) [FIX] Additional scroll when contextual bar is open (RocketChat#16667) [FIX] Clear unread red line when the ESC key is pressed (RocketChat#16668) [FIX] users.info endpoint not handling the error if the user does not exist (RocketChat#16495) Update app/utils/client/lib/RestApiClient.js Update app/utils/client/lib/RestApiClient.js send files over rest api [BUG][FIX] If InternalHubot_Username is undefined then rocket.cat should be default bot Improved isSingular function Add message_pruned and file_pruned for singular file or message deleted ...
gabriellsh
previously approved these changes
Feb 21, 2020
Member
gabriellsh
left a comment
gabriellsh
left a comment
There was a problem hiding this comment.
Looks good to me. Just made some small changes to the method name.
Contributor
|
@subham103 You can rename the function as |
Contributor
Author
|
@ashwaniYDV, actually he already renamed it in one of his commits :p |
gabriellsh
changed the title
Contributor
Author
|
@gabriellsh @ggazzo could you please merge this pr? |
sampaiodiego
approved these changes
Mar 26, 2020
gabriellsh
added a commit
that referenced
this pull request
Mar 26, 2020
…/react-root * 'develop' of github.com:RocketChat/Rocket.Chat: (76 commits) Regression: Fix issue with opening rooms (#17028) Group DM improvements [NEW] Sort channel directory listing by latest message (#16604) [FIX] Wrong message count statistics in Admin info page (#16680) Fix: 2FA DDP method not getting code on API call that doesn’t requires 2FA (#16998) [NEW] Direct message between multiple users (#16761) Bump version to 3.0.7 Regression: Remove deprecated Omnichannel setting used to fetch the queue data through subscription (#17017) Regression: Remove deprecated Omnichannel setting used to fetch the queue data through subscription (#17017) Bump version to 3.0.6 [Regression] Replace the Omnichannel queue model observe with Stream (#16999) [FIX] Keeps the agent in the room after accepting a new Omnichannel request (#16787) [Regression] Replace the Omnichannel queue model observe with Stream (#16999) [NEW] Engagement Dashboard (#16960) Fix StreamCast info (#16995) [IMPROVE] Ability to change offline message button link on emails notifications (#16784) Bump version to 3.0.5 [FIX] Race conditions on/before login (#16989) [FIX] Race conditions on/before login (#16989) Fix: StreamCast was not working correctly (#16983) ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10233
Closes #12610
Previously, the message count for every Room is increased upon message addition but is not updated upon the deletion of a message #12610. So, upon the removal of messages, the message count of rooms shows the wrong message count.
Now the message count of each room is updated upon message deletion, which makes the message count of each room error-free.
So it will be better if we sum up the four values(4 different types of rooms: PrivateGroupMessages, ChannelMessages, DirectMessages, LivechatMessages) to get the exact total message count.