Skip to content

refactor(Livechat): Livechat/Message/markdown.js -> TS#32295

Merged
ggazzo merged 5 commits intodevelopfrom
markdown-livechat-ts
Jul 12, 2024
Merged

refactor(Livechat): Livechat/Message/markdown.js -> TS#32295
ggazzo merged 5 commits intodevelopfrom
markdown-livechat-ts

Conversation

@MartinSchoeler
Copy link
Copy Markdown
Member

@MartinSchoeler MartinSchoeler commented Apr 22, 2024 •
edited by atlassian bot
Loading

Refactors the components/Message/MessageText/Markdown to TS

Part of CORE-305

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.69%. Comparing base (d7de0a9) to head (dcba99e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32295   +/-   ##
========================================
  Coverage    56.68%   56.69%           
========================================
  Files         2504     2504           
  Lines        55524    55524           
  Branches     11442    11442           
========================================
+ Hits         31472    31477    +5     
+ Misses       21368    21359    -9     
- Partials      2684     2688    +4
Flag Coverage Δ
e2e 56.53% <ø> (+0.05%) ⬆️
unit 72.20% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: dcba99e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 23, 2024 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@MartinSchoeler MartinSchoeler added this to the 6.9 milestone Apr 23, 2024
@MartinSchoeler MartinSchoeler marked this pull request as ready for review April 24, 2024 13:15
@MartinSchoeler MartinSchoeler requested review from a team as code owners April 24, 2024 13:15
@scuciatto scuciatto removed this from the 6.9 milestone May 17, 2024
@MartinSchoeler MartinSchoeler added this to the 6.11 milestone Jul 10, 2024
@ggazzo ggazzo merged commit dba2ce4 into develop Jul 12, 2024
@ggazzo ggazzo deleted the markdown-livechat-ts branch July 12, 2024 11:55
gabriellsh added a commit that referenced this pull request Jul 12, 2024
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into apps…
08e175a 
…/removeUsers

* 'develop' of github.com:RocketChat/Rocket.Chat:
  refactor(omnichannel): replace create and find by findAndUpdate (#32773)
  chore: Bump apps engine 1.44-alpha (#32774)
  refactor(client): Remove usage of `React.FC` type (#32760)
  refactor(Livechat): `Livechat/Message/markdown.js` -> TS (#32295)
  refactor(omnichannel): spare few Room.find on requestRoom method (#32363)
  refactor:  `dispatchInquiryPosition` being called multiple times (#32767)
  fix: SAML "Overwrite user fullname" setting is not being honored (#32628)
  fix(Omnichannel): Use Correct components on ChatInfo (#32592)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KevLehman KevLehman KevLehman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.11

Development

Successfully merging this pull request may close these issues.

4 participants

@MartinSchoeler @KevLehman @scuciatto @ggazzo