Skip to content

refactor(client): Remove usage of React.FC type#32760

Merged
ggazzo merged 4 commits intodevelopfrom
refactor/no-fc-type
Jul 12, 2024
Merged

refactor(client): Remove usage of React.FC type#32760
ggazzo merged 4 commits intodevelopfrom
refactor/no-fc-type

Conversation

@tassoevan
Copy link
Copy Markdown
Member

@tassoevan tassoevan commented Jul 11, 2024 •
edited
Loading

Proposed changes (including videos or screenshots)

It changes an ESLint rule in accordance with ADR-0094.

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jul 11, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 11, 2024

⚠️ No Changeset found

Latest commit: 2f69198

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.51282% with 7 lines in your changes missing coverage. Please review.

Project coverage is 56.70%. Comparing base (f2cb691) to head (2f69198).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32760      +/-   ##
===========================================
+ Coverage    56.65%   56.70%   +0.05%     
===========================================
  Files         2504     2504              
  Lines        55524    55526       +2     
  Branches     11442    11446       +4     
===========================================
+ Hits         31456    31488      +32     
+ Misses       21380    21359      -21     
+ Partials      2688     2679       -9
Flag Coverage Δ
e2e 56.52% <96.02%> (+0.07%) ⬆️
e2e-api 40.86% <ø> (+<0.01%) ⬆️
unit 72.31% <90.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan marked this pull request as ready for review July 11, 2024 23:25
@tassoevan tassoevan requested review from a team as code owners July 11, 2024 23:25
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jul 12, 2024
@ggazzo ggazzo added this to the 6.11 milestone Jul 12, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 12, 2024
@ggazzo ggazzo merged commit 99524f2 into develop Jul 12, 2024
@ggazzo ggazzo deleted the refactor/no-fc-type branch July 12, 2024 12:23
gabriellsh added a commit that referenced this pull request Jul 12, 2024
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into apps…
08e175a 
…/removeUsers

* 'develop' of github.com:RocketChat/Rocket.Chat:
  refactor(omnichannel): replace create and find by findAndUpdate (#32773)
  chore: Bump apps engine 1.44-alpha (#32774)
  refactor(client): Remove usage of `React.FC` type (#32760)
  refactor(Livechat): `Livechat/Message/markdown.js` -> TS (#32295)
  refactor(omnichannel): spare few Room.find on requestRoom method (#32363)
  refactor:  `dispatchInquiryPosition` being called multiple times (#32767)
  fix: SAML "Overwrite user fullname" setting is not being honored (#32628)
  fix(Omnichannel): Use Correct components on ChatInfo (#32592)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

6.11

Development

Successfully merging this pull request may close these issues.

2 participants

@tassoevan @ggazzo