Skip to content

refactor(omnichannel): replace create and find by findAndUpdate#32773

Merged
ggazzo merged 3 commits intodevelopfrom
refactor/omichannel-finds
Jul 12, 2024
Merged

refactor(omnichannel): replace create and find by findAndUpdate#32773
ggazzo merged 3 commits intodevelopfrom
refactor/omichannel-finds

Conversation

@ggazzo
Copy link
Copy Markdown
Member

@ggazzo ggazzo commented Jul 12, 2024 •
edited by atlassian bot
Loading

OPI-22

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 64affd8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jul 12, 2024 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.65%. Comparing base (7745bc3) to head (64affd8).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32773      +/-   ##
===========================================
- Coverage    56.66%   56.65%   -0.02%     
===========================================
  Files         2501     2504       +3     
  Lines        55489    55518      +29     
  Branches     11435    11446      +11     
===========================================
+ Hits         31444    31454      +10     
- Misses       21367    21376       +9     
- Partials      2678     2688      +10
Flag Coverage Δ
e2e 56.46% <ø> (-0.03%) ⬇️
unit 72.22% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

ricardogarim
ricardogarim previously approved these changes Jul 12, 2024
View reviewed changes
@ggazzo ggazzo added this to the 6.11 milestone Jul 12, 2024
@ggazzo ggazzo marked this pull request as ready for review July 12, 2024 15:25
@ggazzo ggazzo requested a review from a team as a code owner July 12, 2024 15:25
@ggazzo ggazzo merged commit 0a46a11 into develop Jul 12, 2024
@ggazzo ggazzo deleted the refactor/omichannel-finds branch July 12, 2024 15:59
gabriellsh added a commit that referenced this pull request Jul 12, 2024
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into apps…
08e175a 
…/removeUsers

* 'develop' of github.com:RocketChat/Rocket.Chat:
  refactor(omnichannel): replace create and find by findAndUpdate (#32773)
  chore: Bump apps engine 1.44-alpha (#32774)
  refactor(client): Remove usage of `React.FC` type (#32760)
  refactor(Livechat): `Livechat/Message/markdown.js` -> TS (#32295)
  refactor(omnichannel): spare few Room.find on requestRoom method (#32363)
  refactor:  `dispatchInquiryPosition` being called multiple times (#32767)
  fix: SAML "Overwrite user fullname" setting is not being honored (#32628)
  fix(Omnichannel): Use Correct components on ChatInfo (#32592)
@jessicaschelly jessicaschelly added stat: QA assured Means it has been tested and approved by a company insider and removed stat: needs testing labels Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardogarim ricardogarim ricardogarim approved these changes

@KevLehman KevLehman KevLehman approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider

Projects

None yet

Milestone

6.11

Development

Successfully merging this pull request may close these issues.

4 participants

@ggazzo @ricardogarim @KevLehman @jessicaschelly