feat: Option to disable 2FA for OAuth users#32945
Merged
kodiakhq[bot] merged 29 commits intodevelopfrom Sep 10, 2024
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: b878dc7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32945 +/- ##
===========================================
+ Coverage 59.32% 59.79% +0.47%
===========================================
Files 2548 2548
Lines 63415 63412 -3
Branches 14269 14267 -2
===========================================
+ Hits 37622 37920 +298
+ Misses 23090 23076 -14
+ Partials 2703 2416 -287
Flags with carried forward coverage won't be shown. Click here to find out more. |
yash-rajpal
force-pushed
the
feat/disable-email-2FA-oauth
branch
from
fe7ec40 to
fdb0fac
Compare
KevLehman
requested changes
Aug 1, 2024
Member
KevLehman
left a comment
KevLehman
left a comment
There was a problem hiding this comment.
- Add a PR description
- Is it possible to have some tests? I think 2FA is disabled on TEST_MODE so some units would suffice
KevLehman
reviewed
Aug 2, 2024
matheusbsilva137
suggested changes
Aug 2, 2024
matheusbsilva137
suggested changes
Aug 2, 2024
KevLehman
requested changes
Aug 5, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
KevLehman
previously approved these changes
Aug 21, 2024
yash-rajpal
requested review from
a team
and removed request for
a team,
MarcosSpessatto,
matheusbsilva137 and
tassoevan
matheusbsilva137
suggested changes
Aug 21, 2024
apps/meteor/client/views/account/security/AccountSecurityPage.tsx
Outdated
Show resolved
Hide resolved
matheusbsilva137
approved these changes
Aug 22, 2024
KevLehman
approved these changes
Aug 22, 2024
MarcosSpessatto
approved these changes
Sep 6, 2024
tassoevan
approved these changes
Sep 9, 2024
dionisio-bot
bot
removed
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Sep 11, 2024
…hAvatarById * 'develop' of github.com:RocketChat/Rocket.Chat: fix: Infinite loading when uploading a private app (#33181) chore: publish preview github pages (#33248) chore: move playground (#33260) chore: E2EE setting warning update (#33224) fix: message parser being slow to process very long messages with too many symbols (#33227) chore: fix ui-playground build (#33250) feat: Option to disable 2FA for OAuth users (#32945) fix: Allow to use the token from `room.v` when requesting transcript instead of finding visitor (#33211)
Merged
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Since SSO users are already verified and coming from a reliable source, we don't necessarily need to authenticate TOTP for these users.
Added a new setting which allows workspace admins to disable email two factor authentication for SSO (OAuth) users. If enabled, SSO users won't be asked for email two factor authentication.
Issue(s)
Steps to test or reproduce
Further comments
CORE-566