fix: Allow to use the token from room.v when requesting transcript instead of finding visitor#33211
Merged
kodiakhq[bot] merged 4 commits intodevelopfrom Sep 9, 2024
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 790421a The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #33211 +/- ##
========================================
Coverage 59.32% 59.32%
========================================
Files 2548 2548
Lines 63415 63415
Branches 14268 14269 +1
========================================
Hits 37622 37622
Misses 23090 23090
Partials 2703 2703
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
approved these changes
Sep 6, 2024
MartinSchoeler
approved these changes
Sep 6, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
Member
|
/patch |
dionisio-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
…instead of finding visitor (#33211)
Contributor
|
Pull request #33242 added to Project: "undefined" |
Member
|
/backport 6.11.3 |
dionisio-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
…instead of finding visitor (#33211)
Contributor
|
Pull request #33244 added to Project: "undefined" |
gabriellsh
added a commit
that referenced
this pull request
Sep 11, 2024
…hAvatarById * 'develop' of github.com:RocketChat/Rocket.Chat: fix: Infinite loading when uploading a private app (#33181) chore: publish preview github pages (#33248) chore: move playground (#33260) chore: E2EE setting warning update (#33224) fix: message parser being slow to process very long messages with too many symbols (#33227) chore: fix ui-playground build (#33250) feat: Option to disable 2FA for OAuth users (#32945) fix: Allow to use the token from `room.v` when requesting transcript instead of finding visitor (#33211)
Merged
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 25, 2024
…instead of finding visitor (#33211)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-678
Steps to test or reproduce
Further comments
This happens because of the posibility visitors have from changing their token. This causes visitors to lose access to all previous conversations and interact with any of them, even if they have the token they used at the time.
This new validation should work for those cases, allowing them to request data & transcripts for old conversations given that they know the token even if the token has changed since.