Skip to content

Comments

fix: message parser being slow to process very long messages with too many symbols#33227

Merged
kodiakhq[bot] merged 7 commits intodevelopfrom
fix/message-parser-performance
Sep 11, 2024
Merged

fix: message parser being slow to process very long messages with too many symbols#33227
kodiakhq[bot] merged 7 commits intodevelopfrom
fix/message-parser-performance

Conversation

@pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Sep 6, 2024

Proposed changes (including videos or screenshots)

Issue(s)

CORE-679

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 6, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2024

🦋 Changeset detected

Latest commit: f992cab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/message-parser Patch
@rocket.chat/peggy-loader Patch
@rocket.chat/meteor Patch
@rocket.chat/core-services Patch
@rocket.chat/core-typings Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/rest-typings Patch
rocketchat-services Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 98.71795% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.73%. Comparing base (6730a3c) to head (f992cab).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33227      +/-   ##
===========================================
- Coverage    59.79%   59.73%   -0.07%     
===========================================
  Files         2548     2548              
  Lines        63412    63073     -339     
  Branches     14267    14090     -177     
===========================================
- Hits         37920    37679     -241     
+ Misses       23076    22978      -98     
  Partials      2416     2416              
Flag Coverage Δ
unit 76.95% <98.71%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@scuciatto scuciatto added this to the 6.13 milestone Sep 9, 2024
@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review September 9, 2024 12:37
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Sep 10, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 10, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 10, 2024
@scuciatto scuciatto added the stat: ready to merge PR tested and approved waiting for merge label Sep 11, 2024
@scuciatto scuciatto removed the stat: ready to merge PR tested and approved waiting for merge label Sep 11, 2024
@scuciatto scuciatto added the stat: ready to merge PR tested and approved waiting for merge label Sep 11, 2024
@kodiakhq kodiakhq bot merged commit 79c16d3 into develop Sep 11, 2024
@kodiakhq kodiakhq bot deleted the fix/message-parser-performance branch September 11, 2024 12:20
@scuciatto
Copy link
Member

/patch

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 11, 2024

Pull request #33254 added to Project: "Patch 6.12.1"

@scuciatto
Copy link
Member

/backport 6.11.3

dionisio-bot bot pushed a commit that referenced this pull request Sep 11, 2024
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 11, 2024

Pull request #33255 added to Project: "Patch 6.11.3"

@julio-cfa
Copy link
Contributor

/backport 6.10.6

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 11, 2024

Pull request #33256 added to Project: "undefined"

@julio-cfa
Copy link
Contributor

/backport 6.9.7

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 11, 2024

Pull request #33257 added to Project: "undefined"

@julio-cfa
Copy link
Contributor

/backport 6.8.7

@julio-cfa
Copy link
Contributor

/backport 6.7.9

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 11, 2024

Pull request #33258 added to Project: "undefined"

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 11, 2024

Pull request #33259 added to Project: "undefined"

gabriellsh added a commit that referenced this pull request Sep 11, 2024
…hAvatarById

* 'develop' of github.com:RocketChat/Rocket.Chat:
  fix: Infinite loading when uploading a private app (#33181)
  chore: publish preview github pages (#33248)
  chore: move playground (#33260)
  chore: E2EE setting warning update (#33224)
  fix: message parser being slow to process very long messages with too many symbols (#33227)
  chore: fix ui-playground build (#33250)
  feat: Option to disable 2FA for OAuth users (#32945)
  fix: Allow to use the token from `room.v` when requesting transcript instead of finding visitor (#33211)
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants