Skip to content

Comments

feat: Voip for Team Collaboration#33346

Merged
kodiakhq[bot] merged 14 commits intodevelopfrom
feat/freeswitch-6-12
Sep 30, 2024
Merged

feat: Voip for Team Collaboration#33346
kodiakhq[bot] merged 14 commits intodevelopfrom
feat/freeswitch-6-12

Conversation

@pierre-lehnen-rc
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

This is the feature branch for the new VoIP.

Steps to test or reproduce

Further comments

pierre-lehnen-rc and others added 5 commits September 16, 2024 15:16
* feat: VoIP Backend for FreeSwitch

---------

Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
* feat: Add options to view and assign voice call extensions on the admin's user's list

* chore: changed Roles import to not use index

* chore: added ee/views to unit test build

* test: added VoIP unit tests for UsersTable

* test: added VoIP unit tests for UsersPageHeader

* test: added VoIP unit tests for AssignExtensionModal

* test: added legacyRoot to tests

* test: added await to userEvent.click

* chore: added meteor imports coming from global namespace

* test: added mock for meteor methods

* test: removed module mocks from UsersTable

* test: get by role instead of testId on AssignExtensionModal

* chore: imported Meteor.users not compatible with global Meteor.users type

* Use fake data helpers in unit tests

* feat: improved the user interface

* test: adjusted UserTable unit tests

* Adjust type names

* Replace `voiceCall` with `voip`

---------

Co-authored-by: Tasso <tasso.evangelista@rocket.chat>
* chore: created ui-voip package

* feat: Implemented VoipClient

* feat: implemented useVoipClient

* feat: implemented VoipContext

* feat: implemented VoipProvider

* feat: VoIP freeswitch UI hooks

---------

Co-authored-by: Tasso <tasso.evangelista@rocket.chat>
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 24, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: dd8f41a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/freeswitch Major
@rocket.chat/mock-providers Patch
@rocket.chat/core-services Patch
@rocket.chat/model-typings Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-voip Patch
@rocket.chat/i18n Patch
@rocket.chat/meteor Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/network-broker Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/apps Patch
@rocket.chat/models Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/instance-status Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-video-conf Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pierre-lehnen-rc pierre-lehnen-rc added this to the 6.13 milestone Sep 24, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-30 20:50 UTC

@codecov
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 89.10506% with 56 lines in your changes missing coverage. Please review.

Project coverage is 58.58%. Comparing base (662aca3) to head (dd8f41a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33346      +/-   ##
===========================================
+ Coverage    58.35%   58.58%   +0.22%     
===========================================
  Files         2692     2737      +45     
  Lines        65265    65757     +492     
  Branches     14730    14825      +95     
===========================================
+ Hits         38084    38521     +437     
- Misses       24403    24457      +54     
- Partials      2778     2779       +1     
Flag Coverage Δ
unit 75.68% <89.10%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

pierre-lehnen-rc and others added 4 commits September 24, 2024 11:40
* fix: GenericMenu not respecting button property when disabled

* feat: implemented component DialPad

* feat: implemented component VoipTimer

* feat: implemented component VoipStatus

* feat: implemented component VoipContactId

* feat: implemented component VoipActionButton

* feat: implemented component VoipActions

* feat: implemented component VoipSettingsButton

* feat: implemented component VoipTransferModal

* feat: implemented VoipPopup, views and subcomponents

* chore: removed unnused expression

* chore: added fixme to GenericMenu

* fix: adjusted i18n expression to new standard

* Fix color references

* Suppress missing i18next errors in unit tests

* Add missing npm script

* Align Testing Library version

* test: adjusted selectors to use regex

* test: added unit tests to useVoipDeviceSettings

* Remove stale type imports

* Normalize exports

---------

Co-authored-by: Tasso <tasso.evangelista@rocket.chat>
* feat: added options to useUserInfoQuery

* feat: added freeSwitchExtension to full user data

* feat: added freeSwitchExtension to /v1/im.members

* feat: implemented enable/disable voice call menu item

* feat: implemented start call menu into the room toolbox

* feat: start call actions for user/members contextual bars and user card

* feat: added enable/disable voice call button to NavBarV2

* feat: added dialer button to NavBarV2

* feat: made dialer button primary only if Omnichannel's voip is enabled

* feat: adjusted call toolbox action to be more compatible

* test: adjusted channel and video conf e2e tests to account for the new call menu

* fix: start call menu action not acepting className

* feat: improved error feedback

* Use 'view-user-voip-extension' permission to decide if extension should be loaded

* fix: passing incorrect ref

* fix: adjusted dialer error feedback

* refactor: renamed voice call with voip

* refactor: removed iconOnly prop and kept same behavior with logic

* refactor: reduced the use of useMemo in the useVideoConfMenuOptions hook

* Use `AnchorPortal`

---------

Co-authored-by: Pierre <pierre.lehnen@rocket.chat>
Co-authored-by: Tasso <tasso.evangelista@rocket.chat>
@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review September 27, 2024 02:17
@pierre-lehnen-rc pierre-lehnen-rc requested review from a team as code owners September 27, 2024 02:17
tassoevan
tassoevan previously approved these changes Sep 27, 2024
@tassoevan tassoevan dismissed their stale review September 27, 2024 02:19

missing changesets

tassoevan
tassoevan previously approved these changes Sep 27, 2024
@pierre-lehnen-rc pierre-lehnen-rc modified the milestones: 6.13, 7.0 Sep 30, 2024
Copy link
Member

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@pierre-lehnen-rc pierre-lehnen-rc modified the milestones: 7.0, 6.14 Sep 30, 2024
@pierre-lehnen-rc pierre-lehnen-rc added the stat: ready to merge PR tested and approved waiting for merge label Sep 30, 2024
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Sep 30, 2024
@kodiakhq kodiakhq bot merged commit bcacbb1 into develop Sep 30, 2024
@kodiakhq kodiakhq bot deleted the feat/freeswitch-6-12 branch September 30, 2024 20:50
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
This was referenced Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants