Skip to content

feat: sort_rows of a Table#104

Merged
lars-reimann merged 6 commits intomainfrom
14-method-to-sort-rows-by-specified-criterion
Mar 27, 2023
Merged

feat: sort_rows of a Table#104
lars-reimann merged 6 commits intomainfrom
14-method-to-sort-rows-by-specified-criterion

Conversation

@lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Mar 27, 2023

Closes #14.

Summary of Changes

  • Add a new method sort_rows to the Table class to sort rows using some criteria.
  • Rename the parameter of sort_columns for the sorting criteria to comparator.

@lars-reimann lars-reimann requested a review from a team as a code owner March 27, 2023 19:47
@lars-reimann lars-reimann linked an issue Mar 27, 2023 that may be closed by this pull request
@lars-reimann
Copy link
Member Author

lars-reimann commented Mar 27, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 2 0 0 0.72s
✅ PYTHON flake8 2 0 0.42s
✅ PYTHON isort 2 0 0 0.22s
✅ PYTHON mypy 2 0 1.7s
✅ PYTHON pylint 2 0 2.71s
✅ REPOSITORY git_diff yes no 0.03s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.06%. Comparing base (ec011e4) to head (954e56e).
Report is 504 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   92.04%   92.06%   +0.02%     
==========================================
  Files          36       36              
  Lines        1219     1223       +4     
==========================================
+ Hits         1122     1126       +4     
  Misses         97       97              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann force-pushed the 14-method-to-sort-rows-by-specified-criterion branch from ab6722a to d1dc62e Compare March 27, 2023 19:52
@lars-reimann lars-reimann merged commit 20aaf5e into main Mar 27, 2023
@lars-reimann lars-reimann deleted the 14-method-to-sort-rows-by-specified-criterion branch March 27, 2023 20:06
lars-reimann pushed a commit that referenced this pull request Mar 29, 2023
## [0.7.0](v0.6.0...v0.7.0) (2023-03-29)

### Features

* `sort_rows` of a `Table` ([#104](#104)) ([20aaf5e](20aaf5e)), closes [#14](#14)
* add `_file` suffix to methods interacting with files ([#103](#103)) ([ec011e4](ec011e4))
* improve transformers for tabular data ([#108](#108)) ([b18a06d](b18a06d)), closes [#61](#61) [#90](#90)
* remove `OrdinalEncoder` ([#107](#107)) ([b92bba5](b92bba5)), closes [#61](#61)
* specify features and target when creating a `TaggedTable` ([#114](#114)) ([95e1fc7](95e1fc7)), closes [#27](#27)
* swap `name` and `data` parameters of `Column` ([#105](#105)) ([c2f8da5](c2f8da5))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Method to sort rows by specified criterion

1 participant