feat: swap name and data parameters of Column#105
Merged
lars-reimann merged 3 commits intomainfrom Mar 27, 2023
Merged
Conversation
Member
Author
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov Report
@@ Coverage Diff @@
## main #105 +/- ##
=======================================
Coverage 92.06% 92.06%
=======================================
Files 36 36
Lines 1223 1223
=======================================
Hits 1126 1126
Misses 97 97
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lars-reimann
pushed a commit
that referenced
this pull request
Mar 29, 2023
## [0.7.0](v0.6.0...v0.7.0) (2023-03-29) ### Features * `sort_rows` of a `Table` ([#104](#104)) ([20aaf5e](20aaf5e)), closes [#14](#14) * add `_file` suffix to methods interacting with files ([#103](#103)) ([ec011e4](ec011e4)) * improve transformers for tabular data ([#108](#108)) ([b18a06d](b18a06d)), closes [#61](#61) [#90](#90) * remove `OrdinalEncoder` ([#107](#107)) ([b92bba5](b92bba5)), closes [#61](#61) * specify features and target when creating a `TaggedTable` ([#114](#114)) ([95e1fc7](95e1fc7)), closes [#27](#27) * swap `name` and `data` parameters of `Column` ([#105](#105)) ([c2f8da5](c2f8da5))
Member
Author
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The order of parameters of the
__init__method ofColumnis nowname(was 2.)data(was 1.)type_.Having the
namefirst is more readable since the data can be quite long and highlights that thenameacts as a key and thedataas a value.