Skip to content

feat: improve transformers for tabular data#108

Merged
lars-reimann merged 11 commits intomainfrom
90-return-new-transformer-when-calling-fit
Mar 28, 2023
Merged

feat: improve transformers for tabular data#108
lars-reimann merged 11 commits intomainfrom
90-return-new-transformer-when-calling-fit

Conversation

@lars-reimann
Copy link
Member

Closes #61.
Closes #90.

Summary of Changes

  • Common superclasses TableTransformer and InvertibleTableTransformer
  • Common interface for fit, transform, fit_transform, inverse_transform
  • Return new transformer when calling fit
  • More thorough tests

@lars-reimann lars-reimann requested a review from a team as a code owner March 28, 2023 13:40
@lars-reimann lars-reimann linked an issue Mar 28, 2023 that may be closed by this pull request
@lars-reimann
Copy link
Member Author

lars-reimann commented Mar 28, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 8 0 0 0.7s
✅ PYTHON flake8 8 0 0.42s
✅ PYTHON isort 8 0 0 0.22s
✅ PYTHON mypy 8 0 1.87s
✅ PYTHON pylint 8 0 2.3s
✅ REPOSITORY git_diff yes no 0.03s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #108 (06a3235) into main (b92bba5) will increase coverage by 0.38%.
The diff coverage is 96.96%.

❗ Current head 06a3235 differs from pull request most recent head d0aa8f7. Consider uploading reports for the commit d0aa8f7 to get more accurate results

@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   92.30%   92.68%   +0.38%     
==========================================
  Files          35       36       +1     
  Lines        1182     1217      +35     
==========================================
+ Hits         1091     1128      +37     
+ Misses         91       89       -2     
Impacted Files Coverage Δ
src/safeds/data/tabular/transformation/_imputer.py 92.75% <89.74%> (-5.21%) ⬇️
src/safeds/data/tabular/transformation/__init__.py 100.00% <100.00%> (ø)
...feds/data/tabular/transformation/_label_encoder.py 100.00% <100.00%> (+8.88%) ⬆️
...ds/data/tabular/transformation/_one_hot_encoder.py 100.00% <100.00%> (+4.65%) ⬆️
.../data/tabular/transformation/_table_transformer.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lars-reimann lars-reimann changed the title feat: improve transformers for Table feat: improve transformers for tabular data Mar 28, 2023
@lars-reimann lars-reimann merged commit b18a06d into main Mar 28, 2023
@lars-reimann lars-reimann deleted the 90-return-new-transformer-when-calling-fit branch March 28, 2023 14:06
lars-reimann pushed a commit that referenced this pull request Mar 29, 2023
## [0.7.0](v0.6.0...v0.7.0) (2023-03-29)

### Features

* `sort_rows` of a `Table` ([#104](#104)) ([20aaf5e](20aaf5e)), closes [#14](#14)
* add `_file` suffix to methods interacting with files ([#103](#103)) ([ec011e4](ec011e4))
* improve transformers for tabular data ([#108](#108)) ([b18a06d](b18a06d)), closes [#61](#61) [#90](#90)
* remove `OrdinalEncoder` ([#107](#107)) ([b92bba5](b92bba5)), closes [#61](#61)
* specify features and target when creating a `TaggedTable` ([#114](#114)) ([95e1fc7](95e1fc7)), closes [#27](#27)
* swap `name` and `data` parameters of `Column` ([#105](#105)) ([c2f8da5](c2f8da5))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return new transformer when calling fit Common superclass for transformers

1 participant