feat: Add methods that tell which columns would be affected by a transformer#304
Merged
PhilipGutberlet merged 16 commits intomainfrom May 19, 2023
Conversation
Member
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov Report
@@ Coverage Diff @@
## main #304 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 43 43
Lines 1786 1836 +50
=========================================
+ Hits 1786 1836 +50
|
Co-authored-by: sibre28 <86068340+sibre28@users.noreply.github.com>
Co-authored-by: sibre28 <86068340+sibre28@users.noreply.github.com>
Co-authored-by: sibre28 <86068340+sibre28@users.noreply.github.com>
tests/safeds/data/tabular/transformation/test_one_hot_encoder.py
Outdated
Show resolved
Hide resolved
Marsmaennchen221
requested changes
May 19, 2023
Contributor
Marsmaennchen221
left a comment
Marsmaennchen221
left a comment
There was a problem hiding this comment.
Please add docstrings in imputer, label_encoder and one_hot_encoder for the raised Exceptions.
Please test that the exceptions are being raised
Co-authored-by: sibre28 <86068340+sibre28@users.noreply.github.com>
Contributor
Author
Added docstrings for the |
Co-authored-by: sibre28 <86068340+sibre28@users.noreply.github.com>
Also corrected typo in docstring for Imputer. Co-authored-by: sibre28 <86068340+sibre28@users.noreply.github.com>
Co-authored-by: sibre28 <86068340+sibre28@users.noreply.github.com>
Marsmaennchen221
approved these changes
May 19, 2023
PhilipGutberlet
approved these changes
May 19, 2023
…a-tabletransformer
PhilipGutberlet
deleted the
190-columns-that-are-addedchangedremoved-by-a-tabletransformer
branch
lars-reimann
pushed a commit
that referenced
this pull request
Jun 1, 2023
## [0.13.0](v0.12.0...v0.13.0) (2023-06-01) ### Features * add `Choice` class for possible values of hyperparameter ([#325](#325)) ([d511c3e](d511c3e)), closes [#264](#264) * Add `RangeScaler` transformer ([#310](#310)) ([f687840](f687840)), closes [#141](#141) * Add methods that tell which columns would be affected by a transformer ([#304](#304)) ([3933b45](3933b45)), closes [#190](#190) * Getters for hyperparameters of Regression and Classification models ([#306](#306)) ([5c7a662](5c7a662)), closes [#260](#260) * improve error handling of table ([#308](#308)) ([ef87cc4](ef87cc4)), closes [#147](#147) * Remove warnings thrown in new `Transformer` methods ([#324](#324)) ([ca046c4](ca046c4)), closes [#323](#323)
Member
|
🎉 This PR is included in version 0.13.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #190 .
Summary of Changes
Added abstract methods
get_names_of_added_columns,get_names_of_changed_columns,get_names_of_removed_columnsinTableTransformerclass.Added implementations for all transformers.
Co-authored-by: sibre28 86068340+sibre28@users.noreply.github.com