Skip to content

feat: Remove warnings thrown in new Transformer methods#324

Merged
sibre28 merged 3 commits intomainfrom
323-remove-warnings-from-transformer-methods-added-in-304
May 26, 2023
Merged

feat: Remove warnings thrown in new Transformer methods#324
sibre28 merged 3 commits intomainfrom
323-remove-warnings-from-transformer-methods-added-in-304

Conversation

@zzril
Copy link
Contributor

@zzril zzril commented May 26, 2023

Closes #323.

Summary of Changes

Removed the warnings from get_names_of_added_columns, get_names_of_changed_columns and get_names_of_removed_columns in all transformers.
Updated tests accordingly.

@zzril zzril linked an issue May 26, 2023 that may be closed by this pull request
@zzril zzril changed the title Remove warnings feat: Remove warnings thrown in new Transformer methods May 26, 2023
…rmer-methods-added-in-304' into 323-remove-warnings-from-transformer-methods-added-in-304
@lars-reimann
Copy link
Member

lars-reimann commented May 26, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 8 0 0 0.85s
✅ PYTHON mypy 8 0 1.84s
✅ PYTHON ruff 8 0 0 0.05s
✅ REPOSITORY git_diff yes no 0.03s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #324 (0f84124) into main (2761f47) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #324   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         1986      1975   -11     
=========================================
- Hits          1986      1975   -11     
Impacted Files Coverage Δ
src/safeds/data/tabular/transformation/_imputer.py 100.00% <ø> (ø)
...feds/data/tabular/transformation/_label_encoder.py 100.00% <ø> (ø)
...ds/data/tabular/transformation/_one_hot_encoder.py 100.00% <ø> (ø)
...afeds/data/tabular/transformation/_range_scaler.py 100.00% <ø> (ø)

@zzril zzril marked this pull request as ready for review May 26, 2023 09:30
@zzril zzril requested a review from a team as a code owner May 26, 2023 09:30
Copy link
Contributor

@sibre28 sibre28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@sibre28 sibre28 merged commit ca046c4 into main May 26, 2023
@sibre28 sibre28 deleted the 323-remove-warnings-from-transformer-methods-added-in-304 branch May 26, 2023 09:56
lars-reimann pushed a commit that referenced this pull request Jun 1, 2023
## [0.13.0](v0.12.0...v0.13.0) (2023-06-01)

### Features

* add `Choice` class for possible values of hyperparameter ([#325](#325)) ([d511c3e](d511c3e)), closes [#264](#264)
* Add `RangeScaler` transformer ([#310](#310)) ([f687840](f687840)), closes [#141](#141)
* Add methods that tell which columns would be affected by a transformer ([#304](#304)) ([3933b45](3933b45)), closes [#190](#190)
* Getters for hyperparameters of Regression and Classification models ([#306](#306)) ([5c7a662](5c7a662)), closes [#260](#260)
* improve error handling of table ([#308](#308)) ([ef87cc4](ef87cc4)), closes [#147](#147)
* Remove warnings thrown in new `Transformer` methods ([#324](#324)) ([ca046c4](ca046c4)), closes [#323](#323)
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove warnings from Transformer methods added in #304

3 participants