Merged
Conversation
trexfeathers
requested changes
Feb 8, 2023
Contributor
trexfeathers
left a comment
There was a problem hiding this comment.
Thanks so much for this @bsherratt, very exciting!
A few documentation suggestions for you.
Contributor
|
I expect this will need #5153 before the CI will pass. |
trexfeathers
approved these changes
Feb 10, 2023
Contributor
|
I'm good for this to be merged, but I know @pp-mo wanted a look first |
Member
Thanks for the reminder. |
Member
( Once there is a whatsnew item ! ) |
Contributor
Author
Now added, including an entry in |
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Apr 22, 2023
* upstream/main: (23 commits) Lockfiles and pydata-sphinx-theme fix (SciTools#5188) Allow smarter weights (cubes, coordinates, cell measures, or ancillary variables) for aggregation (SciTools#5084) removed cell measure mask check and error (SciTools#5181) Updated environment lockfiles (SciTools#5177) Lazy weighted RMS calculation (SciTools#5017) Add coverage badge to README.md (SciTools#5176) Add coverage testing (SciTools#4765) Whats new updates for v3.4.1 . NetCDF thread safety take two (SciTools#5095) Updated environment lockfiles (SciTools#5163) Plugin support (SciTools#5144) Expand scope of common contributor links (SciTools#5159) Replace apparently retired UDUNITS documentation link. (SciTools#5153) [pre-commit.ci] pre-commit autoupdate (SciTools#5150) Fixing typo's in Gitwash. (SciTools#5145) add readme #showyourstripes (SciTools#5141) [pre-commit.ci] pre-commit autoupdate (SciTools#5143) Iris ❤ Xarray docs page. (SciTools#5025) [pre-commit.ci] pre-commit autoupdate (SciTools#5136) Updated citation (SciTools#5116) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Plugins! cf #4798 and the older proof of concept #3657.
It uses the same approach of namespace packages, but as
iris.pluginsinstead of limiting ourselves toiris.io.plugins, and does not try to discover which plugins are available (should it..?)This has been successfully used to separate out the NAME loader, although that will be a separate PR once we're happy with the approach to plugins.
Consult Iris pull request check list