removed cell measure mask check and error#5181
Conversation
for more information, see https://pre-commit.ci
|
Hi @ESadek-MO For this, you need to run from an env containing 'pre-commit', and you need (just once) to run "pre-commit install" within you local repo clone (i.e. the checkout on disk). Then it runs black via the There is some written explanation here : https://scitools-iris.readthedocs.io/en/stable/developers_guide/contributing_code_formatting.html?highlight=pre-commit Sorry if you already know all this !! |
…st_Saver__lazy.py
for more information, see https://pre-commit.ci
pp-mo
left a comment
pp-mo
left a comment
There was a problem hiding this comment.
Ok, I think this is OK now, with nothing in place of the old test.
|
Nice job @ESadek-MO . Sorry for all my fretting over the broken test ! |
* upstream/main: (23 commits) Lockfiles and pydata-sphinx-theme fix (SciTools#5188) Allow smarter weights (cubes, coordinates, cell measures, or ancillary variables) for aggregation (SciTools#5084) removed cell measure mask check and error (SciTools#5181) Updated environment lockfiles (SciTools#5177) Lazy weighted RMS calculation (SciTools#5017) Add coverage badge to README.md (SciTools#5176) Add coverage testing (SciTools#4765) Whats new updates for v3.4.1 . NetCDF thread safety take two (SciTools#5095) Updated environment lockfiles (SciTools#5163) Plugin support (SciTools#5144) Expand scope of common contributor links (SciTools#5159) Replace apparently retired UDUNITS documentation link. (SciTools#5153) [pre-commit.ci] pre-commit autoupdate (SciTools#5150) Fixing typo's in Gitwash. (SciTools#5145) add readme #showyourstripes (SciTools#5141) [pre-commit.ci] pre-commit autoupdate (SciTools#5143) Iris ❤ Xarray docs page. (SciTools#5025) [pre-commit.ci] pre-commit autoupdate (SciTools#5136) Updated citation (SciTools#5116) ...
2 participants
🚀 Pull Request
Closes #5147.
Description
Removed check and error raise for saving cubes with masked cell measures.