#5180 do not run publish-to-test-pypi on forks#5220
Conversation
lbdreyer
left a comment
lbdreyer
left a comment
There was a problem hiding this comment.
Thanks for doing this @agriyakhetarpal !
Whilst you are fixing #5180, could you also add the check to the publish to pypi job (here)?
Also, before I can this merge in, you will need to sign the CLA: https://scitools.org.uk/cla/v4/form
This is linked off the SciTools Governance page: https://scitools.org.uk/organisation.html#governance
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #5220 +/- ##
=======================================
Coverage 89.27% 89.27%
=======================================
Files 88 88
Lines 22258 22258
Branches 4867 4867
=======================================
Hits 19871 19871
Misses 1641 1641
Partials 746 746 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Thanks @lbdreyer, added it to the |
|
Awesome, thanks @agriyakhetarpal 🥳 Do you fancy adding a suitable entry into our release notes at the end of the You'll also have to add a reference to your GitHub handle at the end of this section too. If you're not sure about anything, don't hesitate to ask 👍 |
|
Thanks for an awesome first contribution @agriyakhetarpal ! I have already updated the what's new see: 818b3aa All green ticks now, so I'm going to merge! |
|
I was just getting to push those changes, but I see you've already done that – thanks @lbdreyer! 🎉 |
* 'main' of github.com:SciTools/iris: Benchmark runner script (SciTools#5215) add locks readme (SciTools#5222) use explicit version for ci refresh-lockfiles gha (SciTools#5221) SciTools#5180 do not run publish-to-test-pypi on forks (SciTools#5220) Fix Makefile for consequences of SciTools#5204. (SciTools#5217)
* upstream/main: (274 commits) Cf cell method (SciTools#5224) Bump scitools/workflows from 2023.03.3 to 2023.04.1 (SciTools#5231) [pre-commit.ci] pre-commit autoupdate (SciTools#5230) Bump scitools/workflows from 2023.03.2 to 2023.03.3 (SciTools#5227) raise dask min pin (SciTools#5225) Enable lazy computation of wind vector rotation (SciTools#4972) Benchmark runner script (SciTools#5215) add locks readme (SciTools#5222) use explicit version for ci refresh-lockfiles gha (SciTools#5221) SciTools#5180 do not run publish-to-test-pypi on forks (SciTools#5220) Fix Makefile for consequences of SciTools#5204. (SciTools#5217) Bump actions/stale from 7 to 8 (SciTools#5208) Remove Iris' TestRunner (SciTools#5205) standardize requirements structure (SciTools#5204) Updated environment lockfiles (SciTools#5199) Add histogram convenience for passing Iris objects to plt.hist (SciTools#5189) Updated environment lockfiles (SciTools#5192) announce new contributor in whatsnew (SciTools#5198) iris.util.new_axis anonymous new dimension fix (SciTools#5194) Lockfiles and pydata-sphinx-theme fix (SciTools#5188) ...
* Typo github.repository_owner. * What's new entry.
* upstream/main: (29 commits) review actions update .git-blame-ignore-revs adopt codespell Adopt sphinx design (SciTools#5127) Bump scitools/workflows from 2023.04.2 to 2023.04.3 (SciTools#5253) refresh manual pypi publish instructions (SciTools#5252) Updated environment lockfiles (SciTools#5250) removed bugfix section Make bm_runner location agnostic and include debugging. (SciTools#5247) Restore latest Whats New files. SciTools#5220 typo github.repository_owner. (SciTools#5248) Whats new updates for v3.5.0rc0. (SciTools#5246) libnetcdf <4.9 pin (SciTools#5242) update cf standard units (SciTools#5244) Updated environment lockfiles (SciTools#5211) update ci locks location (SciTools#5228) Fixes to _discontiguity_in_bounds (attempt 2) (SciTools#4975) Finalises Lazy Data documentation (SciTools#5137) Modernize and simplify iris.analysis._Groupby (SciTools#5015) clarity on whatsnew entry contributors (SciTools#5240) ...
3 participants
🚀 Pull Request
Description
Checks for 'SciTools' as the repository owner such that
ci_wheels.ymldoes not run the"publish to test.pypi"step in forks, fixes #5180Consult Iris pull request check list