Merged
Conversation
* 'main' of github.com:SciTools/iris: Benchmark runner script (SciTools#5215) add locks readme (SciTools#5222) use explicit version for ci refresh-lockfiles gha (SciTools#5221) SciTools#5180 do not run publish-to-test-pypi on forks (SciTools#5220) Fix Makefile for consequences of SciTools#5204. (SciTools#5217)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5224 +/- ##
==========================================
- Coverage 89.28% 89.28% -0.01%
==========================================
Files 88 88
Lines 22269 22268 -1
Branches 4870 4874 +4
==========================================
- Hits 19882 19881 -1
Misses 1641 1641
Partials 746 746
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
trexfeathers
requested changes
Mar 31, 2023
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Thanks @HGWright, awesome work. Some comments for you...
Contributor
|
Also this pre-commit failure is an easy fix - just remove the import.
|
Member
P.S. you should have been warned of this when you commited, so I guess you are have not installed the pre-commit tool. |
pp-mo
reviewed
Mar 31, 2023
pp-mo
reviewed
Apr 1, 2023
* 'main' of github.com:SciTools/iris: Bump scitools/workflows from 2023.03.2 to 2023.03.3 (SciTools#5227) raise dask min pin (SciTools#5225) Enable lazy computation of wind vector rotation (SciTools#4972)
…l_method * 'cf_cell_method' of github.com:HGWright/iris: [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
trexfeathers
approved these changes
Apr 3, 2023
Contributor
|
Great! I'll merge once this is out of draft |
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Apr 4, 2023
* upstream/main: (274 commits) Cf cell method (SciTools#5224) Bump scitools/workflows from 2023.03.3 to 2023.04.1 (SciTools#5231) [pre-commit.ci] pre-commit autoupdate (SciTools#5230) Bump scitools/workflows from 2023.03.2 to 2023.03.3 (SciTools#5227) raise dask min pin (SciTools#5225) Enable lazy computation of wind vector rotation (SciTools#4972) Benchmark runner script (SciTools#5215) add locks readme (SciTools#5222) use explicit version for ci refresh-lockfiles gha (SciTools#5221) SciTools#5180 do not run publish-to-test-pypi on forks (SciTools#5220) Fix Makefile for consequences of SciTools#5204. (SciTools#5217) Bump actions/stale from 7 to 8 (SciTools#5208) Remove Iris' TestRunner (SciTools#5205) standardize requirements structure (SciTools#5204) Updated environment lockfiles (SciTools#5199) Add histogram convenience for passing Iris objects to plt.hist (SciTools#5189) Updated environment lockfiles (SciTools#5192) announce new contributor in whatsnew (SciTools#5198) iris.util.new_axis anonymous new dimension fix (SciTools#5194) Lockfiles and pydata-sphinx-theme fix (SciTools#5188) ...
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Apr 13, 2023
* upstream/main: (59 commits) Updated environment lockfiles (SciTools#5211) update ci locks location (SciTools#5228) Fixes to _discontiguity_in_bounds (attempt 2) (SciTools#4975) Finalises Lazy Data documentation (SciTools#5137) Modernize and simplify iris.analysis._Groupby (SciTools#5015) clarity on whatsnew entry contributors (SciTools#5240) Handle derived coordinates correctly in `concatenate` (SciTools#5096) Use real array for data of of small netCDF variables. (SciTools#5229) Bump scitools/workflows from 2023.04.1 to 2023.04.2 (SciTools#5236) fixing whatsnew entry remove results creation commit from blame configure codecov adding a whatsnew entry Replacing numpy legacy printing with array2string and remaking results for dependent tests Adding a whatsnew entry for 5224 (SciTools#5234) Cf cell method (SciTools#5224) Bump scitools/workflows from 2023.03.3 to 2023.04.1 (SciTools#5231) [pre-commit.ci] pre-commit autoupdate (SciTools#5230) Bump scitools/workflows from 2023.03.2 to 2023.03.3 (SciTools#5227) raise dask min pin (SciTools#5225) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This is a draft while making sure doctests pass, Also missing a whatsnew entry that will be added when moving out of draft
Finishes #4279.
The cell methods section of the cube printout was not printing in a CF-compliant manner and so this PR goes towards changing that.
Consult Iris pull request check list