Oblique and Rotated Mercator#5548
Merged
bjlittle merged 33 commits intoSciTools:mainfrom Oct 24, 2023
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5548 +/- ##
==========================================
+ Coverage 89.41% 89.44% +0.02%
==========================================
Files 89 89
Lines 22539 22598 +59
Branches 5387 5390 +3
==========================================
+ Hits 20154 20212 +58
Misses 1639 1639
- Partials 746 747 +1
☔ View full report in Codecov by Sentry. |
trexfeathers
commented
Oct 24, 2023
bjlittle
requested changes
Oct 24, 2023
Member
bjlittle
left a comment
bjlittle
left a comment
There was a problem hiding this comment.
@trexfeathers Nice one.
As usual, writing the code is relatively straight forward ... testing, however, is another concern. Neat patterns 🚀
Only a couple of suggestions to service, then we can bank this goodness 😄
...ests/unit/fileformats/nc_load_rules/helpers/test_build_oblique_mercator_coordinate_system.py
Outdated
Show resolved
Hide resolved
bjlittle
approved these changes
Oct 24, 2023
Contributor
Author
|
Big thanks @bjlittle! |
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Oct 26, 2023
* upstream/main: moved latest warning banner logic to conf.py (SciTools#5508) updated layout of top navbar (SciTools#5505) Oblique and Rotated Mercator (SciTools#5548) [pre-commit.ci] pre-commit autoupdate (SciTools#5549) [pre-commit.ci] pre-commit autoupdate (SciTools#5527) Bump scitools/workflows from 2023.09.1 to 2023.10.0 (SciTools#5540) nep29 drop table schedule numpy>1.21 (SciTools#5525) Updated environment lockfiles (SciTools#5545) Replaced `NotImplementedError` with `NotImplemented` (SciTools#5544) Gallery: show colour bar stealing space from multiple axes (SciTools#5537) Updated environment lockfiles (SciTools#5524) Set some memory benchmarks to on-demand to reduce noise. (SciTools#5481) updating docs and stale comment (SciTools#5522) Ensure removal of release candidate from What's New title. (SciTools#5526) Updated environment lockfiles (SciTools#5513) Docs page on filtering warnings (SciTools#5509) Replaced pkg_resources version parser with packager version parser. (SciTools#5511) Categorise warnings (SciTools#5498) Updated all np.product calls to np.prod (SciTools#5493)
HGWright
added a commit
to HGWright/iris
that referenced
this pull request
Nov 17, 2023
* 'guess_coord' of github.com:HGWright/iris: (82 commits) [pre-commit.ci] auto fixes from pre-commit.com hooks [pre-commit.ci] pre-commit autoupdate (SciTools#5579) Relicense to from LGPL-3 to BSD-3 (SciTools#5577) Allow `add_season_year()` to optionally send spans backwards (SciTools#5573) Added xarray phrasebook doc page (SciTools#5564) fixed spacing (SciTools#5572) DOCS: Removed broken git links. (SciTools#5569) More sensible time axis and tick labels for 2D plots (SciTools#5561) removed now incorrect statement. (SciTools#5555) [pre-commit.ci] pre-commit autoupdate (SciTools#5558) Exempt major release label from stalebot (SciTools#5559) updated link (SciTools#5556) Added whatsnew. (SciTools#5552) moved latest warning banner logic to conf.py (SciTools#5508) updated layout of top navbar (SciTools#5505) Oblique and Rotated Mercator (SciTools#5548) [pre-commit.ci] pre-commit autoupdate (SciTools#5549) [pre-commit.ci] pre-commit autoupdate (SciTools#5527) Bump scitools/workflows from 2023.09.1 to 2023.10.0 (SciTools#5540) nep29 drop table schedule numpy>1.21 (SciTools#5525) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Closes #4830
To do
rotated_mercator- always saveoblique_mercatorRotatedMercatorclass, since it will be removed in CF 1.11Base on Correct handling of NetCDF VerticalPerspective and Geostationary coordinate systems #3406 since that included a thorough accounting of coordinate system testing
Consult Iris pull request check list