Allow add_season_year() to optionally send spans backwards#5573
Merged
stephenworsley merged 6 commits intoSciTools:mainfrom Nov 9, 2023
Merged
Allow add_season_year() to optionally send spans backwards#5573stephenworsley merged 6 commits intoSciTools:mainfrom
add_season_year() to optionally send spans backwards#5573stephenworsley merged 6 commits intoSciTools:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5573 +/- ##
=======================================
Coverage 89.44% 89.44%
=======================================
Files 89 89
Lines 22583 22587 +4
Branches 5386 5385 -1
=======================================
+ Hits 20199 20203 +4
Misses 1638 1638
Partials 746 746
☔ View full report in Codecov by Sentry. |
stephenworsley
requested changes
Nov 9, 2023
Contributor
stephenworsley
left a comment
stephenworsley
left a comment
There was a problem hiding this comment.
Good job, I appreciate the diligence moving the tests to pytest format. Just a couple minor notes here.
stephenworsley
approved these changes
Nov 9, 2023
Contributor
stephenworsley
left a comment
stephenworsley
left a comment
There was a problem hiding this comment.
Looks good to me.
Contributor
Author
|
Thanks @stephenworsley! |
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Nov 14, 2023
* main: [pre-commit.ci] pre-commit autoupdate (SciTools#5579) Relicense to from LGPL-3 to BSD-3 (SciTools#5577) Allow `add_season_year()` to optionally send spans backwards (SciTools#5573)
HGWright
added a commit
to HGWright/iris
that referenced
this pull request
Nov 17, 2023
* 'guess_coord' of github.com:HGWright/iris: (82 commits) [pre-commit.ci] auto fixes from pre-commit.com hooks [pre-commit.ci] pre-commit autoupdate (SciTools#5579) Relicense to from LGPL-3 to BSD-3 (SciTools#5577) Allow `add_season_year()` to optionally send spans backwards (SciTools#5573) Added xarray phrasebook doc page (SciTools#5564) fixed spacing (SciTools#5572) DOCS: Removed broken git links. (SciTools#5569) More sensible time axis and tick labels for 2D plots (SciTools#5561) removed now incorrect statement. (SciTools#5555) [pre-commit.ci] pre-commit autoupdate (SciTools#5558) Exempt major release label from stalebot (SciTools#5559) updated link (SciTools#5556) Added whatsnew. (SciTools#5552) moved latest warning banner logic to conf.py (SciTools#5508) updated layout of top navbar (SciTools#5505) Oblique and Rotated Mercator (SciTools#5548) [pre-commit.ci] pre-commit autoupdate (SciTools#5549) [pre-commit.ci] pre-commit autoupdate (SciTools#5527) Bump scitools/workflows from 2023.09.1 to 2023.10.0 (SciTools#5540) nep29 drop table schedule numpy>1.21 (SciTools#5525) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Closes #4877.
The ability for
add_season_year()to assign seasons that span year boundaries (e.g. the standarddjfWinter) to be assigned to the preceding year rather than the following year. #4877 suggested adding an alternative function, but it seemed more appropriate to just add another parameter toadd_season_year().I also took the opportunity to modernise the docstring, and the relevant test module.
To-do
Consult Iris pull request check list