Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5564 +/- ##
=======================================
Coverage 89.44% 89.44%
=======================================
Files 89 89
Lines 22583 22583
Branches 5386 5386
=======================================
Hits 20199 20199
Misses 1638 1638
Partials 746 746 ☔ View full report in Codecov by Sentry. |
stephenworsley
left a comment
stephenworsley
left a comment
There was a problem hiding this comment.
Looking good, Just a couple notes here, mostly I think it's worth being a bit more precise about the differences between Iris and xarray.
Also, there ought to be a link to this documentation page somewhere here https://github.com/SciTools/iris/blob/main/docs/src/community/index.rst and also perhaps here https://github.com/SciTools/iris/blob/main/docs/src/community/iris_xarray.rst .
stephenworsley
left a comment
stephenworsley
left a comment
There was a problem hiding this comment.
Just a couple minor capitalisation changes and this is looking good.
stephenworsley
left a comment
stephenworsley
left a comment
There was a problem hiding this comment.
Looks good to me. Good job!
* 'guess_coord' of github.com:HGWright/iris: (82 commits) [pre-commit.ci] auto fixes from pre-commit.com hooks [pre-commit.ci] pre-commit autoupdate (SciTools#5579) Relicense to from LGPL-3 to BSD-3 (SciTools#5577) Allow `add_season_year()` to optionally send spans backwards (SciTools#5573) Added xarray phrasebook doc page (SciTools#5564) fixed spacing (SciTools#5572) DOCS: Removed broken git links. (SciTools#5569) More sensible time axis and tick labels for 2D plots (SciTools#5561) removed now incorrect statement. (SciTools#5555) [pre-commit.ci] pre-commit autoupdate (SciTools#5558) Exempt major release label from stalebot (SciTools#5559) updated link (SciTools#5556) Added whatsnew. (SciTools#5552) moved latest warning banner logic to conf.py (SciTools#5508) updated layout of top navbar (SciTools#5505) Oblique and Rotated Mercator (SciTools#5548) [pre-commit.ci] pre-commit autoupdate (SciTools#5549) [pre-commit.ci] pre-commit autoupdate (SciTools#5527) Bump scitools/workflows from 2023.09.1 to 2023.10.0 (SciTools#5540) nep29 drop table schedule numpy>1.21 (SciTools#5525) ...
2 participants
Closes #5091.
Created a phrasebook for comparing similar packages.
This is intended as a starting basis, with space for more to be added at a later date.