fix(datasets): raises correct error message on import of protected dataset#1112
Merged
Conversation
| """Get Zenodo files metadata as ``ZenodoFile``.""" | ||
| if len(self.files) == 0: | ||
| if not self.files: | ||
| raise LookupError('no files have been found') |
Contributor
There was a problem hiding this comment.
It's better to mention that there might be protected/restricted files: 'no files have been found or there are files with restricted access'
Contributor
Author
There was a problem hiding this comment.
Sure. Maybe the following wording would work better?
no files have been found - deposit empty or protected
Contributor
There was a problem hiding this comment.
no files have been found - deposit is empty or protected sounds better to me but up to you.
Contributor
mohammad-alisafaee
left a comment
mohammad-alisafaee
left a comment
There was a problem hiding this comment.
Just a wording change.
Panaetius
pushed a commit
that referenced
this pull request
Apr 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #1110
This issue leads to another feature which we currently don't support, but probably should. Jen in that ticket wanted to import a dataset which contains protected files. Now this is currently not supported within renku on any of the providers. We should probably think about building that soon since we have people requesting this.
I created a followup ticket for this: #1113